Re: [PATCH v3 for-7.2 4/6] libvhost-user: Add format attribute to local function vu_panic

[Stefan Weil]

Am 27.11.22 um 19:14 schrieb Stefan Hajnoczi:

> On Sat, 26 Nov 2022 at 10:25, Stefan Weil <sw@weilnetz.de> wrote:
> > Signed-off-by: Stefan Weil <sw@weilnetz.de>
> > Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> > Message-Id: <20220422070144.1043697-4-sw@weilnetz.de>
> > Signed-off-by: Laurent Vivier <laurent@vivier.eu>
> > ---
> >   subprojects/libvhost-user/libvhost-user.c | 13 ++++++++++++-
> >   1 file changed, 12 insertions(+), 1 deletion(-)
> I would rather not merge something that can cause new build failures
> this late in the release cycle.
>
> If you respin, please make this a separate 8.0 patch.


It would only cause a build failure if there remained more format bugs, 
but the last ones were fixed in patch 3. I tested a build for 32 bit ARM 
(which previously failed without patch 3), and it works now.

But you are right, patch 4 is not release critical as it is not a bug 
fix (like the other ones), so not including it in 7.2 might be an option.

Stefan