[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 3/9] ui: Drop disabled code for SPICE_CHANNEL_WEBDAV
From: |
Markus Armbruster |
Subject: |
[PATCH 3/9] ui: Drop disabled code for SPICE_CHANNEL_WEBDAV |
Date: |
Thu, 1 Dec 2022 07:13:05 +0100 |
HMP "info spice" has a bit of code to show channel type
SPICE_CHANNEL_WEBDAV as "webdav", disabled since commit 7c6044a94e
"hmp: info spice: take out webdav" (v2.3.0), because it compiles only
with Spice versions 0.12.7 and later. Our minimum version is 0.12.5.
Looks like nobody minded in more than seven years. Drop it, so that
checkpatch.pl won't complain when I move the code.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
monitor/hmp-cmds.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c
index a7c9ae2520..86dd961462 100644
--- a/monitor/hmp-cmds.c
+++ b/monitor/hmp-cmds.c
@@ -626,12 +626,6 @@ void hmp_info_spice(Monitor *mon, const QDict *qdict)
[SPICE_CHANNEL_SMARTCARD] = "smartcard",
[SPICE_CHANNEL_USBREDIR] = "usbredir",
[SPICE_CHANNEL_PORT] = "port",
-#if 0
- /* minimum spice-protocol is 0.12.3, webdav was added in 0.12.7,
- * no easy way to #ifdef (SPICE_CHANNEL_* is a enum). Disable
- * as quick fix for build failures with older versions. */
- [SPICE_CHANNEL_WEBDAV] = "webdav",
-#endif
};
info = qmp_query_spice(NULL);
--
2.37.3
- [PATCH 0/9] ui: Move and clean up monitor command code, Markus Armbruster, 2022/12/01
- [PATCH 3/9] ui: Drop disabled code for SPICE_CHANNEL_WEBDAV,
Markus Armbruster <=
- Re: [PATCH 3/9] ui: Drop disabled code for SPICE_CHANNEL_WEBDAV, Daniel P . Berrangé, 2022/12/01
- Re: [PATCH 3/9] ui: Drop disabled code for SPICE_CHANNEL_WEBDAV, Markus Armbruster, 2022/12/01
- Re: [PATCH 3/9] ui: Drop disabled code for SPICE_CHANNEL_WEBDAV, Markus Armbruster, 2022/12/01
- Re: [PATCH 3/9] ui: Drop disabled code for SPICE_CHANNEL_WEBDAV, Daniel P . Berrangé, 2022/12/01
- Re: [PATCH 3/9] ui: Drop disabled code for SPICE_CHANNEL_WEBDAV, Markus Armbruster, 2022/12/01
- Re: [PATCH 3/9] ui: Drop disabled code for SPICE_CHANNEL_WEBDAV, Daniel P . Berrangé, 2022/12/01
- Re: [PATCH 3/9] ui: Drop disabled code for SPICE_CHANNEL_WEBDAV, Markus Armbruster, 2022/12/02
[PATCH 4/9] ui: Clean up a few things checkpatch.pl would flag later on, Markus Armbruster, 2022/12/01
[PATCH 1/9] ui: Check numeric part of expire_password argument @time properly, Markus Armbruster, 2022/12/01