[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 1/5] tests/qtests: override "force-legacy" for gpio virtio-mmio te
From: |
Michael S. Tsirkin |
Subject: |
[PULL 1/5] tests/qtests: override "force-legacy" for gpio virtio-mmio tests |
Date: |
Thu, 1 Dec 2022 02:38:03 -0500 |
From: Alex Bennée <alex.bennee@linaro.org>
The GPIO device is a VIRTIO_F_VERSION_1 devices but running with a
legacy MMIO interface we miss out that feature bit causing confusion.
For the GPIO test force the mmio bus to support non-legacy so we can
properly test it.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1333
Message-Id: <20221130112439.2527228-2-alex.bennee@linaro.org>
Acked-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
tests/qtest/libqos/virtio-gpio.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/qtest/libqos/virtio-gpio.c b/tests/qtest/libqos/virtio-gpio.c
index 762aa6695b..f22d7b5eb5 100644
--- a/tests/qtest/libqos/virtio-gpio.c
+++ b/tests/qtest/libqos/virtio-gpio.c
@@ -154,7 +154,8 @@ static void virtio_gpio_register_nodes(void)
QOSGraphEdgeOptions edge_opts = { };
/* vhost-user-gpio-device */
- edge_opts.extra_device_opts = "id=gpio0,chardev=chr-vhost-user-test";
+ edge_opts.extra_device_opts = "id=gpio0,chardev=chr-vhost-user-test "
+ "-global virtio-mmio.force-legacy=false";
qos_node_create_driver("vhost-user-gpio-device",
virtio_gpio_device_create);
qos_node_consumes("vhost-user-gpio-device", "virtio-bus", &edge_opts);
--
MST
- [PULL 0/5] virtio: regression fix, Michael S. Tsirkin, 2022/12/01
- [PULL 1/5] tests/qtests: override "force-legacy" for gpio virtio-mmio tests,
Michael S. Tsirkin <=
- [PULL 4/5] hw/virtio: generalise CHR_EVENT_CLOSED handling, Michael S. Tsirkin, 2022/12/01
- [PULL 5/5] include/hw: VM state takes precedence in virtio_device_should_start, Michael S. Tsirkin, 2022/12/01
- [PULL 2/5] vhost: enable vrings in vhost_dev_start() for vhost-user devices, Michael S. Tsirkin, 2022/12/01
- [PULL 3/5] hw/virtio: add started_vu status field to vhost-user-gpio, Michael S. Tsirkin, 2022/12/01
- Re: [PULL 0/5] virtio: regression fix, Stefan Hajnoczi, 2022/12/04