Re: [PATCH v2 7/7] accel/tcg: Move remainder of page locking to tb-maint.c

[Alex Bennée]

Richard Henderson <richard.henderson@linaro.org> writes:

> The only thing that still touches PageDesc in translate-all.c
> are some locking routines related to tb-maint.c which have not
> yet been moved.  Do so now.
>
> Move some code up in tb-maint.c as well, to untangle the maze
> of ifdefs, and allow a sensible final ordering.
>
> Move some declarations from exec/translate-all.h to internal.h,
> as they are only used within accel/tcg/.
>
> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
<snip>
>  #ifdef CONFIG_USER_ONLY
> +
> +/*
> + * In user-mode page locks aren't used; mmap_lock is enough.
> + */
> +#define assert_page_locked(pd) tcg_debug_assert(have_mmap_lock())
> +
> +static inline void page_lock_pair(PageDesc **ret_p1, tb_page_addr_t phys1,
> +                                  PageDesc **ret_p2, tb_page_addr_t phys2,
> +                                  bool alloc)
> +{
> +    *ret_p1 = NULL;
> +    *ret_p2 = NULL;
> +}
> +
> +static inline void page_lock(PageDesc *pd) { }
> +static inline void page_unlock(PageDesc *pd) { }
> +static inline void page_lock_tb(const TranslationBlock *tb) { }
> +static inline void page_unlock_tb(const TranslationBlock *tb) { }
> +
<snip>

clang picks up that page_lock is unused in this branch of the code.

-- 
Alex Bennée