[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 02/14] ui: Fix silent truncation of numeric keys in HMP sendke
From: |
Markus Armbruster |
Subject: |
[PATCH v2 02/14] ui: Fix silent truncation of numeric keys in HMP sendkey |
Date: |
Fri, 2 Dec 2022 11:05:00 +0100 |
Keys are int. HMP sendkey assigns them from the value strtoul(),
silently truncating values greater than INT_MAX. Fix to reject them.
While there, use qemu_strtoul() instead of strtoul() so checkpatch.pl
won't complain.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
---
monitor/hmp-cmds.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c
index 01b789a79e..a7c9ae2520 100644
--- a/monitor/hmp-cmds.c
+++ b/monitor/hmp-cmds.c
@@ -1666,8 +1666,13 @@ void hmp_sendkey(Monitor *mon, const QDict *qdict)
v = g_malloc0(sizeof(*v));
if (strstart(keys, "0x", NULL)) {
- char *endp;
- int value = strtoul(keys, &endp, 0);
+ const char *endp;
+ unsigned long value;
+
+ if (qemu_strtoul(keys, &endp, 0, &value) < 0
+ || value >= INT_MAX) {
+ goto err_out;
+ }
assert(endp <= keys + keyname_len);
if (endp != keys + keyname_len) {
goto err_out;
--
2.37.3
- [PATCH v2 00/14] ui: Move and clean up monitor command code, Markus Armbruster, 2022/12/02
- [PATCH v2 03/14] ui/spice: Require spice-protocol >= 0.14.0, Markus Armbruster, 2022/12/02
- [PATCH v2 01/14] ui: Check numeric part of expire_password argument @time properly, Markus Armbruster, 2022/12/02
- [PATCH v2 04/14] Revert "hmp: info spice: take out webdav", Markus Armbruster, 2022/12/02
- [PATCH v2 02/14] ui: Fix silent truncation of numeric keys in HMP sendkey,
Markus Armbruster <=
- [PATCH v2 14/14] ui: Reduce nesting in hmp_change_vnc() slightly, Markus Armbruster, 2022/12/02
- [PATCH v2 12/14] ui: Improve "change vnc" error reporting, Markus Armbruster, 2022/12/02
- [PATCH v2 10/14] ui: Factor out qmp_add_client() parts and move to ui/ui-qmp-cmds.c, Markus Armbruster, 2022/12/02
- [PATCH v2 07/14] ui/spice: Give hmp_info_spice()'s channel_names[] static linkage, Markus Armbruster, 2022/12/02
- [PATCH v2 08/14] ui: Clean up a few things checkpatch.pl would flag later on, Markus Armbruster, 2022/12/02
- [PATCH v2 13/14] ui: Factor out hmp_change_vnc(), and move to ui/ui-hmp-cmds.c, Markus Armbruster, 2022/12/02
- [PATCH v2 06/14] ui/spice: QXLInterface method set_mm_time() is now dead, drop, Markus Armbruster, 2022/12/02