qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH for 8.0] configure: repeat ourselves for the benefit of C


From: Philippe Mathieu-Daudé
Subject: Re: [RFC PATCH for 8.0] configure: repeat ourselves for the benefit of CI
Date: Fri, 2 Dec 2022 20:04:14 +0100
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.5.0

On 2/12/22 18:47, Alex Bennée wrote:
Our CI system echos the lines it executes but not the expansions. For
the sake of a line of extra verbosity during the configure phase lets
echo the invocation of script to stdout as well as the log.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
  configure | 7 ++++---
  1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/configure b/configure
index 26c7bc5154..849ac7aed9 100755
--- a/configure
+++ b/configure
@@ -83,9 +83,10 @@ rm -f config.log
  # Print a helpful header at the top of config.log
  echo "# QEMU configure log $(date)" >> config.log
  printf "# Configured with:" >> config.log
-printf " '%s'" "$0" "$@" >> config.log
-echo >> config.log
-echo "#" >> config.log
+# repeat the invocation to log and stdout for CI
+invoke=$(printf " '%s'" "$0" "$@")
+echo "configuring with: $invoke"

   test -n $GITLAB_CI && ... ?

+{ echo "$invoke"; echo; echo "#"; } >> config.log
quote_sh() {
      printf "%s" "$1" | sed "s,','\\\\'',g; s,.*,'&',"




reply via email to

[Prev in Thread] Current Thread [Next in Thread]