[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 04/11] qapi/migration: Introduce x-vcpu-dirty-limit-period
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v2 04/11] qapi/migration: Introduce x-vcpu-dirty-limit-period parameter |
Date: |
Sat, 03 Dec 2022 10:06:15 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
huangy81@chinatelecom.cn writes:
> From: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
>
> Introduce "x-vcpu-dirty-limit-period" migration experimental
> parameter, which is in the range of 1 to 1000ms and used to
> make dirtyrate calculation period configurable.
>
> Signed-off-by: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
[...]
> diff --git a/qapi/migration.json b/qapi/migration.json
> index 88ecf86..5175779 100644
> --- a/qapi/migration.json
> +++ b/qapi/migration.json
> @@ -776,8 +776,13 @@
> # block device name if there is one, and to their
> node name
> # otherwise. (Since 5.2)
> #
> +# @x-vcpu-dirty-limit-period: Periodic time (ms) of dirty limit during live
> migration.
> +# Should be in the range 1 to 1000ms, defaults
> to 500ms.
> +# (Since 7.1)
8.0
> +#
> # Features:
> -# @unstable: Member @x-checkpoint-delay is experimental.
> +# @unstable: Member @x-checkpoint-delay and @x-vcpu-dirty-limit-period
Members
> +# are experimental.
> #
> # Since: 2.4
> ##
> @@ -795,8 +800,9 @@
> 'multifd-channels',
> 'xbzrle-cache-size', 'max-postcopy-bandwidth',
> 'max-cpu-throttle', 'multifd-compression',
> - 'multifd-zlib-level' ,'multifd-zstd-level',
> - 'block-bitmap-mapping' ] }
> + 'multifd-zlib-level', 'multifd-zstd-level',
> + 'block-bitmap-mapping',
> + { 'name': 'x-vcpu-dirty-limit-period', 'features': ['unstable'] }
> ] }
>
> ##
> # @MigrateSetParameters:
> @@ -941,8 +947,13 @@
> # block device name if there is one, and to their
> node name
> # otherwise. (Since 5.2)
> #
> +# @x-vcpu-dirty-limit-period: Periodic time (ms) of dirty limit during live
> migration.
> +# Should be in the range 1 to 1000ms, defaults
> to 500ms.
> +# (Since 7.1)
> +#
> # Features:
> -# @unstable: Member @x-checkpoint-delay is experimental.
> +# @unstable: Member @x-checkpoint-delay and @x-vcpu-dirty-limit-period
Members
> +# are experimental.
> #
> # Since: 2.4
> ##
> @@ -976,7 +987,9 @@
> '*multifd-compression': 'MultiFDCompression',
> '*multifd-zlib-level': 'uint8',
> '*multifd-zstd-level': 'uint8',
> - '*block-bitmap-mapping': [ 'BitmapMigrationNodeAlias' ] } }
> + '*block-bitmap-mapping': [ 'BitmapMigrationNodeAlias' ],
> + '*x-vcpu-dirty-limit-period': { 'type': 'uint64',
> + 'features': [ 'unstable' ] } } }
>
> ##
> # @migrate-set-parameters:
> @@ -1141,8 +1154,13 @@
> # block device name if there is one, and to their
> node name
> # otherwise. (Since 5.2)
> #
> +# @x-vcpu-dirty-limit-period: Periodic time (ms) of dirty limit during live
> migration.
> +# Should be in the range 1 to 1000ms, defaults
> to 500ms.
> +# (Since 7.1)
> +#
> # Features:
> -# @unstable: Member @x-checkpoint-delay is experimental.
> +# @unstable: Member @x-checkpoint-delay and @x-vcpu-dirty-limit-period
Members
> +# are experimental.
> #
> # Since: 2.4
> ##
> @@ -1174,7 +1192,9 @@
> '*multifd-compression': 'MultiFDCompression',
> '*multifd-zlib-level': 'uint8',
> '*multifd-zstd-level': 'uint8',
> - '*block-bitmap-mapping': [ 'BitmapMigrationNodeAlias' ] } }
> + '*block-bitmap-mapping': [ 'BitmapMigrationNodeAlias' ],
> + '*x-vcpu-dirty-limit-period': { 'type': 'uint64',
> + 'features': [ 'unstable' ] } } }
>
> ##
> # @query-migrate-parameters:
- Re: [PATCH v2 04/11] qapi/migration: Introduce x-vcpu-dirty-limit-period parameter,
Markus Armbruster <=