[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 05/11] qapi/migration: Introduce vcpu-dirty-limit paramete
|
From: |
Markus Armbruster |
|
Subject: |
Re: [PATCH v2 05/11] qapi/migration: Introduce vcpu-dirty-limit parameters |
|
Date: |
Sat, 03 Dec 2022 10:21:09 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Markus Armbruster <armbru@redhat.com> writes:
> huangy81@chinatelecom.cn writes:
>
>> From: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
>>
>> Introduce "vcpu-dirty-limit" migration parameter used
>> to limit dirty page rate during live migration.
>>
>> "vcpu-dirty-limit" and "x-vcpu-dirty-limit-period" are
>> two dirty-limit-related migration parameters, which can
>> be set before and during live migration by qmp
>> migrate-set-parameters.
>>
>> This two parameters are used to help implement the dirty
>> page rate limit algo of migration.
>>
>> Signed-off-by: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
>
> Could you explain briefly why x-vcpu-dirty-limit-period is experimental,
> and vcpu-dirty-limit is not?
Prior discussion under "[PATCH v1 3/8] migration: Introduce dirty-limit
capability". I'm not asking you to explain all over again, I'm asking
you to try to work rationale into the commit message.