[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 02/10] softmmu/dirtylimit: Add parameter check for hmp "set_vc
From: |
huangy81 |
Subject: |
[PATCH v3 02/10] softmmu/dirtylimit: Add parameter check for hmp "set_vcpu_dirty_limit" |
Date: |
Sun, 4 Dec 2022 00:38:47 +0800 |
From: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
dirty_rate paraemter of hmp command "set_vcpu_dirty_limit" is invalid
if less than 0, so add parameter check for it.
Note that this patch also delete the unsolicited help message and
clean up the code.
Signed-off-by: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
---
softmmu/dirtylimit.c | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/softmmu/dirtylimit.c b/softmmu/dirtylimit.c
index 940d238..53b66d5 100644
--- a/softmmu/dirtylimit.c
+++ b/softmmu/dirtylimit.c
@@ -515,14 +515,15 @@ void hmp_set_vcpu_dirty_limit(Monitor *mon, const QDict
*qdict)
int64_t cpu_index = qdict_get_try_int(qdict, "cpu_index", -1);
Error *err = NULL;
- qmp_set_vcpu_dirty_limit(!!(cpu_index != -1), cpu_index, dirty_rate, &err);
- if (err) {
- hmp_handle_error(mon, err);
- return;
+ if (dirty_rate < 0) {
+ error_setg(&err, "invalid dirty page limit %ld", dirty_rate);
+ goto out;
}
- monitor_printf(mon, "[Please use 'info vcpu_dirty_limit' to query "
- "dirty limit for virtual CPU]\n");
+ qmp_set_vcpu_dirty_limit(!!(cpu_index != -1), cpu_index, dirty_rate, &err);
+
+out:
+ hmp_handle_error(mon, err);
}
static struct DirtyLimitInfo *dirtylimit_query_vcpu(int cpu_index)
--
1.8.3.1
- [PATCH v3 00/10] migration: introduce dirtylimit capabilit, huangy81, 2022/12/03
- [PATCH v3 03/10] kvm: dirty-ring: Fix race with vcpu creation, huangy81, 2022/12/03
- [PATCH v3 02/10] softmmu/dirtylimit: Add parameter check for hmp "set_vcpu_dirty_limit",
huangy81 <=
- [PATCH v3 01/10] dirtylimit: Fix overflow when computing MB, huangy81, 2022/12/03
- [PATCH v3 05/10] qapi/migration: Introduce vcpu-dirty-limit parameters, huangy81, 2022/12/03
- [PATCH v3 07/10] migration: Refactor auto-converge capability logic, huangy81, 2022/12/03
- [PATCH v3 06/10] migration: Introduce dirty-limit capability, huangy81, 2022/12/03
- [PATCH v3 04/10] qapi/migration: Introduce x-vcpu-dirty-limit-period parameter, huangy81, 2022/12/03
- [PATCH v3 08/10] migration: Implement dirty-limit convergence algo, huangy81, 2022/12/03
- [PATCH v3 09/10] migration: Export dirty-limit time info for observation, huangy81, 2022/12/03
- [PATCH v3 10/10] tests: Add migration dirty-limit capability test, huangy81, 2022/12/03