[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[RFC PATCH for 8.0 02/13] vhost: iterate only available descriptors at S
From: |
Eugenio Pérez |
Subject: |
[RFC PATCH for 8.0 02/13] vhost: iterate only available descriptors at SVQ stop |
Date: |
Mon, 5 Dec 2022 18:04:25 +0100 |
While we're at it, simplify the free path making just transverse the
list instead of all of them.
Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
---
hw/virtio/vhost-shadow-virtqueue.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/hw/virtio/vhost-shadow-virtqueue.c
b/hw/virtio/vhost-shadow-virtqueue.c
index 0da72cb0ec..1bda8ca4bf 100644
--- a/hw/virtio/vhost-shadow-virtqueue.c
+++ b/hw/virtio/vhost-shadow-virtqueue.c
@@ -692,12 +692,13 @@ void vhost_svq_stop(VhostShadowVirtqueue *svq)
/* Send all pending used descriptors to guest */
vhost_svq_flush(svq, false);
- for (unsigned i = 0; i < svq->vring.num; ++i) {
+ while (!QTAILQ_EMPTY(&svq->desc_state_avail)) {
+ SVQDescState *s = QTAILQ_FIRST(&svq->desc_state_avail);
g_autofree VirtQueueElement *elem = NULL;
- elem = g_steal_pointer(&svq->desc_state[i].elem);
- if (elem) {
- virtqueue_detach_element(svq->vq, elem, 0);
- }
+
+ elem = g_steal_pointer(&s->elem);
+ virtqueue_detach_element(svq->vq, elem, 0);
+ QTAILQ_REMOVE(&svq->desc_state_avail, s, entry);
}
next_avail_elem = g_steal_pointer(&svq->next_guest_avail_elem);
--
2.31.1
- [RFC PATCH for 8.0 00/13] vDPA-net inflight descriptors migration with SVQ, Eugenio Pérez, 2022/12/05
- [RFC PATCH for 8.0 01/13] vhost: add available descriptor list in SVQ, Eugenio Pérez, 2022/12/05
- [RFC PATCH for 8.0 02/13] vhost: iterate only available descriptors at SVQ stop,
Eugenio Pérez <=
- [RFC PATCH for 8.0 03/13] vhost: merge avail list and next avail descriptors detach, Eugenio Pérez, 2022/12/05
- [RFC PATCH for 8.0 04/13] vhost: add vhost_svq_save_inflight, Eugenio Pérez, 2022/12/05
- [RFC PATCH for 8.0 07/13] virtio: refactor qemu_put_virtqueue_element, Eugenio Pérez, 2022/12/05
- [RFC PATCH for 8.0 05/13] virtio: Specify uint32_t as VirtQueueElementOld members type, Eugenio Pérez, 2022/12/05
- [RFC PATCH for 8.0 06/13] virtio: refactor qemu_get_virtqueue_element, Eugenio Pérez, 2022/12/05
- [RFC PATCH for 8.0 10/13] virtio-net: Migrate vhost inflight descriptors, Eugenio Pérez, 2022/12/05