qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 for-8.0] hw/misc: Move some arm-related files from specifi


From: Peter Maydell
Subject: Re: [PATCH v2 for-8.0] hw/misc: Move some arm-related files from specific_ss into softmmu_ss
Date: Mon, 5 Dec 2022 17:09:26 +0000

On Fri, 2 Dec 2022 at 16:32, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>
> On 2/12/22 16:40, Thomas Huth wrote:
> > The header arget/arm/kvm-consts.h checks CONFIG_KVM which is marked as
>
> typo "target"
>
> > poisoned in common code, so the files that include this header have to
> > be added to specific_ss and recompiled for each, qemu-system-arm and
> > qemu-system-aarch64. However, since the kvm headers are only optionally
> > used in kvm-constants.h for some sanity checks, we can additionally
> > check the NEED_CPU_H macro first to avoid the poisoned CONFIG_KVM macro,
> > so kvm-constants.h can also be used from "common" files (without the
> > sanity checks - which should be OK since they are still done from other
> > target-specific files instead). This way, and by adjusting some other
> > include statements in the related files here and there, we can move some
> > files from specific_ss into softmmu_ss, so that they only need to be
> > compiled once during the build process.
>
> Cool!
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Applied to target-arm-for-8.0 with the commit message
typo fixed.

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]