[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[RFC PATCH 21/21] i386/xen: implement HYPERVISOR_sched_op
From: |
David Woodhouse |
Subject: |
[RFC PATCH 21/21] i386/xen: implement HYPERVISOR_sched_op |
Date: |
Mon, 5 Dec 2022 17:31:37 +0000 |
From: Joao Martins <joao.m.martins@oracle.com>
It allows to shutdown itself via hypercall with any of the 3 reasons:
1) self-reboot
2) shutdown
3) crash
Implementing SCHEDOP_shutdown sub op let us handle crashes gracefully rather
than leading to triple faults if it remains unimplemented.
Signed-off-by: Joao Martins <joao.m.martins@oracle.com>
Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
---
target/i386/xen.c | 44 ++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 44 insertions(+)
diff --git a/target/i386/xen.c b/target/i386/xen.c
index f3cc240bff..9606f5978a 100644
--- a/target/i386/xen.c
+++ b/target/i386/xen.c
@@ -15,6 +15,7 @@
#include "xen.h"
#include "trace.h"
#include "sysemu/sysemu.h"
+#include "sysemu/runstate.h"
#define __XEN_INTERFACE_VERSION__ 0x00040400
@@ -23,6 +24,7 @@
#include "standard-headers/xen/hvm/hvm_op.h"
#include "standard-headers/xen/hvm/params.h"
#include "standard-headers/xen/vcpu.h"
+#include "standard-headers/xen/sched.h"
#include "standard-headers/xen/event_channel.h"
#define PAGE_OFFSET 0xffffffff80000000UL
@@ -476,6 +478,44 @@ static int kvm_xen_hcall_evtchn_op(struct kvm_xen_exit
*exit,
return err ? HCALL_ERR : 0;
}
+static int schedop_shutdown(CPUState *cs, uint64_t arg)
+{
+ struct sched_shutdown *shutdown;
+
+ shutdown = gva_to_hva(cs, arg);
+ if (!shutdown) {
+ return -EFAULT;
+ }
+
+ if (shutdown->reason == SHUTDOWN_crash) {
+ cpu_dump_state(cs, stderr, CPU_DUMP_CODE);
+ qemu_system_guest_panicked(NULL);
+ } else if (shutdown->reason == SHUTDOWN_reboot) {
+ qemu_system_reset_request(SHUTDOWN_CAUSE_GUEST_RESET);
+ } else if (shutdown->reason == SHUTDOWN_poweroff) {
+ qemu_system_shutdown_request(SHUTDOWN_CAUSE_GUEST_SHUTDOWN);
+ }
+
+ return 0;
+}
+
+static int kvm_xen_hcall_sched_op(struct kvm_xen_exit *exit, X86CPU *cpu,
+ int cmd, uint64_t arg)
+{
+ CPUState *cs = CPU(cpu);
+ int err = -ENOSYS;
+
+ switch (cmd) {
+ case SCHEDOP_shutdown: {
+ err = schedop_shutdown(cs, arg);
+ break;
+ }
+ }
+
+ exit->u.hcall.result = err;
+ return err;
+}
+
static int __kvm_xen_handle_exit(X86CPU *cpu, struct kvm_xen_exit *exit)
{
uint16_t code = exit->u.hcall.input;
@@ -489,6 +529,10 @@ static int __kvm_xen_handle_exit(X86CPU *cpu, struct
kvm_xen_exit *exit)
case HVMOP_set_evtchn_upcall_vector:
return kvm_xen_hcall_evtchn_upcall_vector(exit, cpu,
exit->u.hcall.params[0]);
+ case __HYPERVISOR_sched_op_compat:
+ case __HYPERVISOR_sched_op:
+ return kvm_xen_hcall_sched_op(exit, cpu, exit->u.hcall.params[0],
+ exit->u.hcall.params[1]);
case __HYPERVISOR_event_channel_op_compat:
return kvm_xen_hcall_evtchn_op_compat(exit, cpu,
exit->u.hcall.params[0]);
--
2.35.3
- Re: [RFC PATCH 18/21] kvm/ioapic: mark gsi-2 used in ioapic routing init, (continued)
[RFC PATCH 21/21] i386/xen: implement HYPERVISOR_sched_op,
David Woodhouse <=
[RFC PATCH 10/21] i386/xen: handle guest hypercalls, David Woodhouse, 2022/12/05
- Re: [RFC PATCH 10/21] i386/xen: handle guest hypercalls, Philippe Mathieu-Daudé, 2022/12/05
- Re: [RFC PATCH 10/21] i386/xen: handle guest hypercalls, David Woodhouse, 2022/12/05
- Re: [RFC PATCH 10/21] i386/xen: handle guest hypercalls, Philippe Mathieu-Daudé, 2022/12/06
- Re: [RFC PATCH 10/21] i386/xen: handle guest hypercalls, David Woodhouse, 2022/12/06
- Re: [RFC PATCH 10/21] i386/xen: handle guest hypercalls, Philippe Mathieu-Daudé, 2022/12/06
- Re: [RFC PATCH 10/21] i386/xen: handle guest hypercalls, David Woodhouse, 2022/12/06
Re: [RFC PATCH 10/21] i386/xen: handle guest hypercalls, Alex Bennée, 2022/12/06
[RFC PATCH 20/21] i386/xen: implement HYPERVISOR_event_channel_op, David Woodhouse, 2022/12/05