[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 2/2] vdpa: commit all host notifier MRs in a single MR transac
From: |
Longpeng(Mike) |
Subject: |
[PATCH v2 2/2] vdpa: commit all host notifier MRs in a single MR transaction |
Date: |
Tue, 6 Dec 2022 16:18:41 +0800 |
From: Longpeng <longpeng2@huawei.com>
This allows the vhost-vdpa device to batch the setup of all its MRs of
host notifiers.
This significantly reduces the device starting time, e.g. the time spend
on setup the host notifier MRs reduce from 423ms to 32ms for a VM with
64 vCPUs and 3 vhost-vDPA generic devices[1] (64vq per device).
[1] https://www.mail-archive.com/qemu-devel@nongnu.org/msg921541.html
Signed-off-by: Longpeng <longpeng2@huawei.com>
---
hw/virtio/vhost-vdpa.c | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c
index 7468e44b87..eb233cf08a 100644
--- a/hw/virtio/vhost-vdpa.c
+++ b/hw/virtio/vhost-vdpa.c
@@ -547,9 +547,18 @@ static void vhost_vdpa_host_notifiers_uninit(struct
vhost_dev *dev, int n)
{
int i;
+ /*
+ * Pack all the changes to the memory regions in a single
+ * transaction to avoid a few updating of the address space
+ * topology.
+ */
+ memory_region_transaction_begin();
+
for (i = dev->vq_index; i < dev->vq_index + n; i++) {
vhost_vdpa_host_notifier_uninit(dev, i);
}
+
+ memory_region_transaction_commit();
}
static void vhost_vdpa_host_notifiers_init(struct vhost_dev *dev)
@@ -562,16 +571,25 @@ static void vhost_vdpa_host_notifiers_init(struct
vhost_dev *dev)
return;
}
+ /*
+ * Pack all the changes to the memory regions in a single
+ * transaction to avoid a few updating of the address space
+ * topology.
+ */
+ memory_region_transaction_begin();
+
for (i = dev->vq_index; i < dev->vq_index + dev->nvqs; i++) {
if (vhost_vdpa_host_notifier_init(dev, i)) {
goto err;
}
}
+ memory_region_transaction_commit();
return;
err:
vhost_vdpa_host_notifiers_uninit(dev, i - dev->vq_index);
+ memory_region_transaction_commit();
return;
}
--
2.23.0
- [PATCH v2 0/2] two optimizations to speed up the start time, Longpeng(Mike), 2022/12/06
- [PATCH v2 1/2] vhost: configure all host notifiers in a single MR transaction, Longpeng(Mike), 2022/12/06
- Re: [PATCH v2 1/2] vhost: configure all host notifiers in a single MR transaction, Philippe Mathieu-Daudé, 2022/12/06
- Re: [PATCH v2 1/2] vhost: configure all host notifiers in a single MR transaction, Longpeng (Mike, Cloud Infrastructure Service Product Dept.), 2022/12/06
- Re: [PATCH v2 1/2] vhost: configure all host notifiers in a single MR transaction, Philippe Mathieu-Daudé, 2022/12/06
- Re: [PATCH v2 1/2] vhost: configure all host notifiers in a single MR transaction, Longpeng (Mike, Cloud Infrastructure Service Product Dept.), 2022/12/06
- Re: [PATCH v2 1/2] vhost: configure all host notifiers in a single MR transaction, Michael S. Tsirkin, 2022/12/20
[PATCH v2 2/2] vdpa: commit all host notifier MRs in a single MR transaction,
Longpeng(Mike) <=