[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Thoughts on removing the TARGET_I386 part of hw/display/vga/vbe_port
|
From: |
Gerd Hoffmann |
|
Subject: |
Re: Thoughts on removing the TARGET_I386 part of hw/display/vga/vbe_portio_list[] |
|
Date: |
Tue, 6 Dec 2022 15:38:58 +0100 |
Hi,
> So on x86 we can have 16-bit I/O accesses unaligned to 8-bit boundary?
Yes.
> So I _think_ today we should be good with removing the x86 line:
>
> -# ifdef TARGET_I386
> - { 1, 1, 2, .read = vbe_ioport_read_data, .write = vbe_ioport_write_data
> },
> -# endif
Nope. Breaks vgabios. Testcase:
qemu-system-x86_64 -kernel /boot/vmlinuz-$(uname -r) -append vga=ask
All graphics modes are gone.
take care,
Gerd