[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 02/11] exec: Restrict hwaddr.h to sysemu/
From: |
Claudio Fontana |
Subject: |
Re: [PATCH 02/11] exec: Restrict hwaddr.h to sysemu/ |
Date: |
Wed, 7 Dec 2022 11:09:58 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 |
On 12/6/22 18:09, Philippe Mathieu-Daudé wrote:
> On 6/12/22 16:38, Claudio Fontana wrote:
>> On 12/6/22 15:53, Claudio Fontana wrote:
>>> On 5/17/21 13:11, Philippe Mathieu-Daudé wrote:
>>>> Guard declarations within hwaddr.h against inclusion
>>>> from user-mode emulation.
>>>>
>>>> To make it clearer this header is sysemu specific,
>>>> move it to the sysemu/ directory.
>>>
>>> Hi Philippe,
>>>
>>> do we need include/exec/sysemu/... .h
>>>
>>> as opposed to just use the existing
>>>
>>> include/sysemu/
>>>
>>> ?
>>
>> ...and I would if anything go include/sysemu/exec/ not include/exec/sysemu ,
>>
>> to highlight first that it is part of the sysemu build, when trying to
>> reason about what gets built for sysemu vs anything else.
>
> While refreshing this series I moved these files directly in
> include/sysemu/. Do you think the exec/ subdirectory {help|meaning}ful?
>
Hi Philippe, not so much, I think include/sysemu/ is enough.
Ciao,
Claudio