[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 00/18] block: Introduce a block graph rwlock
From: |
Kevin Wolf |
Subject: |
Re: [PATCH 00/18] block: Introduce a block graph rwlock |
Date: |
Wed, 7 Dec 2022 17:08:47 +0100 |
Am 07.12.2022 um 15:12 hat Emanuele Giuseppe Esposito geschrieben:
> > Emanuele Giuseppe Esposito (7):
> > graph-lock: Implement guard macros
> > async: Register/unregister aiocontext in graph lock list
> > block: wrlock in bdrv_replace_child_noperm
> > block: remove unnecessary assert_bdrv_graph_writable()
> > block: assert that graph read and writes are performed correctly
> > block-coroutine-wrapper.py: introduce annotations that take the graph
> > rdlock
> > block: use co_wrapper_mixed_bdrv_rdlock in functions taking the rdlock
> >
> > Kevin Wolf (10):
> > block: Factor out bdrv_drain_all_begin_nopoll()
> > Import clang-tsa.h
> > clang-tsa: Add TSA_ASSERT() macro
> > clang-tsa: Add macros for shared locks
> > configure: Enable -Wthread-safety if present
> > test-bdrv-drain: Fix incorrrect drain assumptions
> > block: Fix locking in external_snapshot_prepare()
> > graph-lock: TSA annotations for lock/unlock functions
> > Mark assert_bdrv_graph_readable/writable() GRAPH_RD/WRLOCK
> > block: GRAPH_RDLOCK for functions only called by co_wrappers
> >
> > Paolo Bonzini (1):
> > graph-lock: Introduce a lock to protect block graph operations
> >
> Reviewed-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Thanks!
> ^ I am curious to see if I am allowed to have my r-b also on my patches :)
That's actually a good question. I wondered myself whether I should add
my R-b to patches that I picked up from you, but which already have my
S-o-b now, of course, and are possibly modified by me.
I would say you're allowed as long as you actually reviewed them in the
version I sent to make sure that I didn't mess them up. :-)
And similarly I'll probably add my R-b on patches that contain code from
you.
Kevin
- [PATCH 12/18] block: remove unnecessary assert_bdrv_graph_writable(), (continued)
- [PATCH 12/18] block: remove unnecessary assert_bdrv_graph_writable(), Kevin Wolf, 2022/12/07
- [PATCH 11/18] block: wrlock in bdrv_replace_child_noperm, Kevin Wolf, 2022/12/07
- [PATCH 15/18] Mark assert_bdrv_graph_readable/writable() GRAPH_RD/WRLOCK, Kevin Wolf, 2022/12/07
- [PATCH 13/18] block: assert that graph read and writes are performed correctly, Kevin Wolf, 2022/12/07
- [PATCH 17/18] block: use co_wrapper_mixed_bdrv_rdlock in functions taking the rdlock, Kevin Wolf, 2022/12/07
- [PATCH 18/18] block: GRAPH_RDLOCK for functions only called by co_wrappers, Kevin Wolf, 2022/12/07
- [PATCH 16/18] block-coroutine-wrapper.py: introduce annotations that take the graph rdlock, Kevin Wolf, 2022/12/07
- [PATCH 14/18] graph-lock: TSA annotations for lock/unlock functions, Kevin Wolf, 2022/12/07
- [PATCH 09/18] test-bdrv-drain: Fix incorrrect drain assumptions, Kevin Wolf, 2022/12/07
- Re: [PATCH 00/18] block: Introduce a block graph rwlock, Emanuele Giuseppe Esposito, 2022/12/07