Re: [PULL 11/21] docs: Build and install all the docs in a single manual

[Peter Maydell]

On Thu, 8 Dec 2022 at 06:55, Stefan Weil <sw@weilnetz.de> wrote:
>
> Am 12.01.21 um 17:57 schrieb Peter Maydell:
> [...]
> > diff --git a/docs/meson.build b/docs/meson.build

> > +  sphinxdocs += this_manual
> > +  install_subdir(output_dir, install_dir: qemu_docdir, strip_directory: 
> > true)
>
> This line causes a build warning with the latest code:
>
> ../../../docs/meson.build:74: WARNING: Project targets '>=0.61.3' but
> uses feature deprecated since '0.60.0': install_subdir with empty
> directory. It worked by accident and is buggy. Use install_emptydir instead.
>
> It looks like `qemu_docdir` is no longer defined anywhere.

It's defined by the top-level meson.build, in line 39:

qemu_docdir = get_option('docdir') / get_option('qemu_suffix')

The warning from meson is not about the value of install_dir,
though : it's saying "the directory you asked me to install from
the build tree doesn't exist, I'm going to create an empty
subdirectory in the install destination, but there's better ways
to do that if that's what you were intending to do". So the
question is why your build tree doesn't have the documentation
built in it -- it should be in $BUILDDIR/docs/manual/ .

thanks
-- PMM