qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 04/16] hw/riscv: Sort machines Kconfig options in alphabet


From: Wilfred Mallawa
Subject: Re: [PATCH v2 04/16] hw/riscv: Sort machines Kconfig options in alphabetical order
Date: Thu, 8 Dec 2022 22:45:13 +0000

On Wed, 2022-12-07 at 18:03 +0800, Bin Meng wrote:
> SHAKTI_C machine Kconfig option was inserted in disorder. Fix it.
> 
> Signed-off-by: Bin Meng <bmeng@tinylab.org>
> Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Wilfred Mallawa <wilfred.mallawa@wdc.com>

Wilfred
> ---
> 
> (no changes since v1)
> 
>  hw/riscv/Kconfig | 16 +++++++++-------
>  1 file changed, 9 insertions(+), 7 deletions(-)
> 
> diff --git a/hw/riscv/Kconfig b/hw/riscv/Kconfig
> index 1e4b58024f..4550b3b938 100644
> --- a/hw/riscv/Kconfig
> +++ b/hw/riscv/Kconfig
> @@ -4,6 +4,8 @@ config RISCV_NUMA
>  config IBEX
>      bool
>  
> +# RISC-V machines in alphabetical order
> +
>  config MICROCHIP_PFSOC
>      bool
>      select CADENCE_SDHCI
> @@ -22,13 +24,6 @@ config OPENTITAN
>      select SIFIVE_PLIC
>      select UNIMP
>  
> -config SHAKTI_C
> -    bool
> -    select UNIMP
> -    select SHAKTI_UART
> -    select RISCV_ACLINT
> -    select SIFIVE_PLIC
> -
>  config RISCV_VIRT
>      bool
>      imply PCI_DEVICES
> @@ -50,6 +45,13 @@ config RISCV_VIRT
>      select FW_CFG_DMA
>      select PLATFORM_BUS
>  
> +config SHAKTI_C
> +    bool
> +    select RISCV_ACLINT
> +    select SHAKTI_UART
> +    select SIFIVE_PLIC
> +    select UNIMP
> +
>  config SIFIVE_E
>      bool
>      select RISCV_ACLINT


reply via email to

[Prev in Thread] Current Thread [Next in Thread]