Re: [PATCH 16/30] build: move glib detection and workarounds to meson

[Philippe Mathieu-Daudé]

On 9/12/22 12:23, Paolo Bonzini wrote:
> QEMU adds the path to glib.h is added to all compilation commands.

add/add/ not clear...

Otherwise:
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>


> This is simpler due to the pervasive use of static_library, and was
> grandfathered in from the previous Make-based build system.  Until
> Meson 0.63 the only way to do this was to detect glib in configure
> and use add_project_arguments, but now it is possible to use
> add_project_dependencies instead.
>
> gmodule is detected in a separate variable and added via both
> block_ss (for --enable-modules) and plugins/meson.build (for
> --enable-plugins).
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>   block/meson.build        |  1 +
>   configure                | 83 +---------------------------------------
>   contrib/plugins/Makefile |  4 +-
>   meson.build              | 81 +++++++++++++++++++++++++++++++++------
>   plugins/meson.build      |  2 +-
>   5 files changed, 74 insertions(+), 97 deletions(-)