qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 03/30] configure: remove useless test


From: Paolo Bonzini
Subject: Re: [PATCH 03/30] configure: remove useless test
Date: Fri, 9 Dec 2022 17:35:36 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0

On 12/9/22 12:34, Peter Maydell wrote:
-# Using uname is really, really broken.  Once we have the right set of checks
-# we can eliminate its usage altogether.
I note that the fallback if we match no #defines is still "use uname".
We can only get rid of that if we're willing to say "must be a
known host architecture, even if using TCI", though. Or we could
force the 1 person using that setup to specify --cpu manually, perhaps.

Ok I'll change a bit the comments, and add a warning in configure as well if the #define checks fail to detect the CPU architecture.

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]