Re: [RFC PATCH v2 10/22] i386/xen: handle guest hypercalls

[Paolo Bonzini]

On 12/9/22 10:56, David Woodhouse wrote:
> +static bool __kvm_xen_handle_exit(X86CPU *cpu, struct kvm_xen_exit *exit)

No double underscores in userspace.

> +{
> +    uint16_t code = exit->u.hcall.input;
> +
> +    if (exit->u.hcall.cpl > 0) {
> +        exit->u.hcall.result = -EPERM;
> +        return true;
> +    }
> +
> +    switch (code) {
> +    default:
> +        return false;
> +    }
> +}
> +
> +int kvm_xen_handle_exit(X86CPU *cpu, struct kvm_xen_exit *exit)

BTW, please name this file either target/i386/xen-emu.c or 
target/i386/kvm/xen-emu.c (probably the latter is better, since XEN_EMU 
depends on KVM.)

Paolo