qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1 06/24] vfio-user: Define type vfio_user_pci_dev_info


From: John Johnson
Subject: Re: [PATCH v1 06/24] vfio-user: Define type vfio_user_pci_dev_info
Date: Mon, 12 Dec 2022 21:32:33 +0000


> On Dec 12, 2022, at 1:01 AM, Cédric Le Goater <clg@redhat.com> wrote:
> 
> On 11/9/22 00:13, John Johnson wrote:
>> 
>> +
>> +static Property vfio_user_pci_dev_properties[] = {
>> +    DEFINE_PROP_STRING("socket", VFIOUserPCIDevice, sock_name),
> 
> This looks like a good candidate for using a chardev. It could only
> support AF_UNIX to start with if fd passing is the required feature.
> But at least, the model would be using a well known backend. I think
> vhost has the same kind of constraints.
> 

        It should be a SocketAddress, but there is no command line
parser for that.  The next best option was to name the struct members
individually, so a string for addr.u.q_unix.path

                                                        JJ



reply via email to

[Prev in Thread] Current Thread [Next in Thread]