[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH v2 13/22] i386/xen: implement HYPERVISOR_memory_op
From: |
David Woodhouse |
Subject: |
Re: [RFC PATCH v2 13/22] i386/xen: implement HYPERVISOR_memory_op |
Date: |
Tue, 13 Dec 2022 00:08:30 +0000 |
User-agent: |
Evolution 3.36.5-0ubuntu1 |
On Mon, 2022-12-12 at 14:38 +0000, Paul Durrant wrote:
>
> > + switch (xatp.space) {
> > + case XENMAPSPACE_shared_info:
> > + break;
> > + default:
> > + err = -ENOSYS;
> > + break;
>
> Don't you want to return false here?
It doesn't make a lot of difference right now. Once we believe we've
implemented everything a sane guest would use, then the distinction
between {true, -ENOSYS} and just returning false actually starts to
matter.
smime.p7s
Description: S/MIME cryptographic signature
- [RFC PATCH v2 00/22] Xen HVM support under KVM, David Woodhouse, 2022/12/09
- [RFC PATCH v2 07/22] pc_piix: handle XEN_EMULATE backend init, David Woodhouse, 2022/12/09
- [RFC PATCH v2 08/22] xen_platform: exclude vfio-pci from the PCI platform unplug, David Woodhouse, 2022/12/09
- [RFC PATCH v2 13/22] i386/xen: implement HYPERVISOR_memory_op, David Woodhouse, 2022/12/09
- [RFC PATCH v2 20/22] i386/xen: HVMOP_set_param / HVM_PARAM_CALLBACK_IRQ, David Woodhouse, 2022/12/09
- Re: [RFC PATCH v2 20/22] i386/xen: HVMOP_set_param / HVM_PARAM_CALLBACK_IRQ, Paul Durrant, 2022/12/12
- Re: [RFC PATCH v2 20/22] i386/xen: HVMOP_set_param / HVM_PARAM_CALLBACK_IRQ, David Woodhouse, 2022/12/12
- Re: [RFC PATCH v2 20/22] i386/xen: HVMOP_set_param / HVM_PARAM_CALLBACK_IRQ, Paul Durrant, 2022/12/12
- Re: [RFC PATCH v2 20/22] i386/xen: HVMOP_set_param / HVM_PARAM_CALLBACK_IRQ, David Woodhouse, 2022/12/15
- Re: [RFC PATCH v2 20/22] i386/xen: HVMOP_set_param / HVM_PARAM_CALLBACK_IRQ, Paul Durrant, 2022/12/20
- Re: [RFC PATCH v2 20/22] i386/xen: HVMOP_set_param / HVM_PARAM_CALLBACK_IRQ, David Woodhouse, 2022/12/20
- Re: [RFC PATCH v2 20/22] i386/xen: HVMOP_set_param / HVM_PARAM_CALLBACK_IRQ, Paul Durrant, 2022/12/20
- Re: [RFC PATCH v2 20/22] i386/xen: HVMOP_set_param / HVM_PARAM_CALLBACK_IRQ, David Woodhouse, 2022/12/20
- Re: [RFC PATCH v2 20/22] i386/xen: HVMOP_set_param / HVM_PARAM_CALLBACK_IRQ, David Woodhouse, 2022/12/28