Re: [RFC PATCH-for-8.0 06/10] hw/virtio: Cache access_is_big_endian value in VirtIODevice state

[Richard Henderson]

On 12/13/22 01:30, Philippe Mathieu-Daudé wrote:
> On 13/12/22 01:14, Richard Henderson wrote:
> > On 12/12/22 17:05, Philippe Mathieu-Daudé wrote:
> > > The device endianness doesn't change during runtime.
> >
> > What are you talking about?  Of course it does.
>
> The host CPU certainly does, but the virtio device doesn't... Does it?
>
> This check only consider the device, not the CPU:
>
>      bool virtio_access_is_big_endian(VirtIODevice *vdev)
>      {
>      #if defined(LEGACY_VIRTIO_IS_BIENDIAN)
>          return virtio_is_big_endian(vdev);

This is set for both ARM and PPC, which checks current cpu endianness in both 
cases.

> and once the features are negotiated it doesn't seem to change.

Incorrect.


r~