[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/3] qapi, audio: respect build time conditions in audio sche
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH 2/3] qapi, audio: respect build time conditions in audio schema |
Date: |
Wed, 14 Dec 2022 11:28:10 +0000 |
User-agent: |
Mutt/2.2.7 (2022-08-07) |
On Mon, Dec 12, 2022 at 05:53:21PM +0100, Thomas Huth wrote:
> On 02/03/2021 18.55, Daniel P. Berrangé wrote:
> > Currently the -audiodev accepts any audiodev type regardless of what is
> > built in to QEMU. An error only occurs later at runtime when a sound
> > device tries to use the audio backend.
> >
> > With this change QEMU will immediately reject -audiodev args that are
> > not compiled into the binary. The QMP schema will also be introspectable
> > to identify what is compiled in.
> >
> > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> > ---
> > audio/audio.c | 16 +++++++++++++++
> > audio/audio_legacy.c | 41 ++++++++++++++++++++++++++++++++++++++-
> > audio/audio_template.h | 16 +++++++++++++++
> > qapi/audio.json | 44 ++++++++++++++++++++++++++++++++----------
> > 4 files changed, 106 insertions(+), 11 deletions(-)
>
> Hi Daniel!
>
> Would you have time to respin this patch for QEMU 8.0 ?
Realistically I'm not going to get it soon. If you want to take over
feel free.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|