Re: [PULL 00/30] QAPI patches patches for 2022-12-14

[Peter Maydell]

On Wed, 14 Dec 2022 at 07:48, Markus Armbruster <armbru@redhat.com> wrote:
>
> The following changes since commit ea3a008d2d9ced9c4f93871c823baee237047f93:
>
>   Update VERSION for v7.2.0-rc4 (2022-12-06 19:53:34 -0500)
>
> are available in the Git repository at:
>
>   https://repo.or.cz/qemu/armbru.git tags/pull-qapi-2022-12-14
>
> for you to fetch changes up to 4fd14ed8e5432f2998ec63922e3146c017ce8fc8:
>
>   qapi: Drop temporary logic to support conversion step by step (2022-12-13 
> 18:31:38 +0100)
>
> ----------------------------------------------------------------
> QAPI patches patches for 2022-12-14

Hi; I'm afraid this fails to build on multiple platforms:

https://gitlab.com/qemu-project/qemu/-/pipelines/722490645

Symptoms generally seem to be missing fields in QAPI-defined
structs, eg most of the CI fails on this one:

../block/rbd.c: In function ‘qemu_rbd_do_create’:
../block/rbd.c:545:15: error: ‘BlockdevCreateOptionsRbd’ has no member
named ‘has_encrypt’; did you mean ‘encrypt’?
545 | if (opts->has_encrypt) {
| ^~~~~~~~~~~
| encrypt

I also saw these errors on a local macos build:

../../net/vmnet-host.c:42:18: error: no member named 'has_net_uuid' in
'struct NetdevVmnetHostOptions'; did you mean 'net_uuid'?
../../net/vmnet-host.c:50:19: error: no member named
'has_start_address' in 'struct NetdevVmnetHostOptions'; did you mean
'start_address'?
../../net/vmnet-host.c:51:19: error: no member named 'has_end_address'
in 'struct NetdevVmnetHostOptions'; did you mean 'end_address'?
../../net/vmnet-host.c:52:19: error: no member named 'has_subnet_mask'
in 'struct NetdevVmnetHostOptions'; did you mean 'subnet_mask'?
../../net/vmnet-host.c:53:20: error: no member named
'has_start_address' in 'struct NetdevVmnetHostOptions'; did you mean
'start_address'?
../../net/vmnet-host.c:54:20: error: no member named 'has_end_address'
in 'struct NetdevVmnetHostOptions'; did you mean 'end_address'?
(and others in that struct in the same file)

The macos CI build also fails with
../ui/cocoa.m:1485:39: error: too many arguments to function call,
expected 5, have 7
calling qmp_eject() and similarly with qmp_blockdev_change_medium():
https://gitlab.com/qemu-project/qemu/-/jobs/3474118201

thanks
-- PMM