Re: [PATCH] tests/qtest/qom-test: Do not print tested properties by default

[Peter Maydell]

On Thu, 15 Dec 2022 at 14:01, Thomas Huth <thuth@redhat.com> wrote:
>
> We're still running into the problem that some logs are cut in the
> gitlab-CI since they got too big. The biggest part of the log is
> still the output of the qom-test. Let's stop printing the properties
> by default to get to a saner size here. The full output can still
> be enabled by setting V=2 (or higher) in the environment.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>

> @@ -103,6 +107,12 @@ static void add_machine_test_case(const char *mname)
>
>  int main(int argc, char **argv)
>  {
> +    char *v_env = getenv("V");
> +
> +    if (v_env && *v_env >= '2') {
> +        verbose = true;
> +    }

This is a bit cheesy -- I think we should parse the string
to a number properly rather than accepting '2', '23',
'2.89237', '2e45' '2fast2furious' etc :-)

thanks
-- PMM