Re: [PATCH] linux-user: Add translation for argument of msync()

[Richard Henderson]

On 12/14/22 23:58, Philippe Mathieu-Daudé wrote:
> > --- a/linux-user/alpha/target_mman.h
> > +++ b/linux-user/alpha/target_mman.h
> > @@ -3,6 +3,10 @@
> >
> >   #define TARGET_MADV_DONTNEED 6
> >
> > +#define TARGET_MS_ASYNC 1
> > +#define TARGET_MS_SYNC 2
> > +#define TARGET_MS_INVALIDATE 4
> > +
> >   #include "../generic/target_mman.h"
> >
> >   #endif
> > diff --git a/linux-user/generic/target_mman.h b/linux-user/generic/target_mman.h
> > index 1436a3c543..32bf1a52d0 100644
> > --- a/linux-user/generic/target_mman.h
> > +++ b/linux-user/generic/target_mman.h
> > @@ -89,4 +89,17 @@
> >   #define TARGET_MADV_DONTNEED_LOCKED 24
> >   #endif
> >
> > +
> > +#ifndef TARGET_MS_ASYNC
> > +#define TARGET_MS_ASYNC 1
>
> Hmm don't we want to keep the host flag instead?
>
>     #define TARGET_MS_ASYNC MS_ASYNC

No.  What if the host has an odd value, like Alpha.


r~