Re: [RFC PATCH] includes: move tb_flush into its own header

[Alex Bennée]

Richard Henderson <richard.henderson@linaro.org> writes:

> On 12/15/22 06:09, Alex Bennée wrote:
>> This aids subsystems (like gdbstub) that want to trigger a flush
>> without pulling target specific headers.
>> [AJB: RFC because this is part of a larger gdbstub series but I
>> wanted
>> to post for feedback in case anyone wants to suggest better naming].
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> ---
>>   include/exec/exec-all.h     | 1 -
>>   linux-user/user-internals.h | 1 +
>>   accel/tcg/tb-maint.c        | 1 +
>>   accel/tcg/translate-all.c   | 1 +
>>   cpu.c                       | 1 +
>>   gdbstub/gdbstub.c           | 1 +
>>   hw/ppc/spapr_hcall.c        | 1 +
>>   plugins/core.c              | 1 +
>>   plugins/loader.c            | 2 +-
>>   target/alpha/sys_helper.c   | 1 +
>>   target/riscv/csr.c          | 1 +
>>   11 files changed, 10 insertions(+), 2 deletions(-)
>
> It appears as if you forgot to add tb-common.h.
> That said, if this is intended to have exactly one thing, tb-flush.h
> might be better.

I'll rename and include when I send the gdbstub stuff. I don't know how
far you want to go to eliminate target specific handling from the rest
of TB maintenance - indeed I'm not sure anything else is possible? 

>
>
> r~


-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro