Re: [PATCH 1/5] io: Add support for MSG_PEEK for socket channel

[manish.mishra]

On 15/12/22 11:05 pm, Peter Xu wrote:
> On Thu, Dec 15, 2022 at 09:40:41AM +0000, Daniel P. Berrangé wrote:
> > On Wed, Dec 14, 2022 at 04:30:48PM -0500, Peter Xu wrote:
> > > On Wed, Dec 14, 2022 at 09:14:09AM +0000, Daniel P. Berrangé wrote:
> > > > On Tue, Dec 13, 2022 at 04:38:46PM -0500, Peter Xu wrote:
> > > > > From: "manish.mishra" <manish.mishra@nutanix.com>
> > > > >
> > > > > MSG_PEEK reads from the peek of channel, The data is treated as
> > > > > unread and the next read shall still return this data. This
> > > > > support is currently added only for socket class. Extra parameter
> > > > > 'flags' is added to io_readv calls to pass extra read flags like
> > > > > MSG_PEEK.
> > > > >
> > > > > Reviewed-by: Daniel P. Berrang?? <berrange@redhat.co
> > > > > Suggested-by: Daniel P. Berrang?? <berrange@redhat.com
> > > > The last letter of my name has been mangled - whatever tools used
> > > > to pull in manish's patches seem to not be UTF-8 clean.
> > > >
> > > > Also the email addr isn't terminated, but that was pre-existing
> > > > in manish's previous posting.


Yes sorry, noticed it now, should i send another patch to update it. Also in 
our internal testing we noticed multifd_init was skipped for 1 case, so if this 
patch series is not yet submitted should i send another version of it early 
morning monday?

Thanks

Manish Mishra

> > > I'll fix at least the latter in my next post, sorry.
> > >
> > > For the 1st one - I am still looking at what went wrong.
> > >
> > > Here from the web interfaces it all looks good (besides the wrong
> > > ending..), e.g. on lore or patchew:
> > >
> > > https://urldefense.proofpoint.com/v2/url?u=https-3A__lore.kernel.org_all_20221213213850.1481858-2D2-2Dpeterx-40redhat.com_&d=DwIDaQ&c=s883GpUCOChKOHiocYtGcg&r=c4KON2DiMd-szjwjggQcuUvTsPWblztAL0gVzaHnNmc&m=UYXwYmi1YA2mdAgHNDIkmgh-Xbem8hmqgCedCRNaj-32GKMVK8X30wH3nnXE9VF9&s=_9G0TGvGLvwCdB7vumPEboQqcrX5RoaxZ_4aZTnMDzY&e=
> > > https://urldefense.proofpoint.com/v2/url?u=https-3A__patchew.org_QEMU_20221213213850.1481858-2D1-2Dpeterx-40redhat.com_20221213213850.1481858-2D2-2Dpeterx-40redhat.com_&d=DwIDaQ&c=s883GpUCOChKOHiocYtGcg&r=c4KON2DiMd-szjwjggQcuUvTsPWblztAL0gVzaHnNmc&m=UYXwYmi1YA2mdAgHNDIkmgh-Xbem8hmqgCedCRNaj-32GKMVK8X30wH3nnXE9VF9&s=Nv0ek8VsMHEDFdQ--vwCOrwxT_u1KqbV9014SQzI1kQ&e=
> > >
> > > It also looks good with e.g. Gmail webclient.
> > >
> > > Then I digged into the email headers and I found that comparing to Manish's
> > > original message, the patches I posted has one more line of "Content-type":
> > >
> > >    Content-Type: text/plain; charset="utf-8"
> > >    Content-type: text/plain
> > >    
> > > https://urldefense.proofpoint.com/v2/url?u=https-3A__patchew.org_QEMU_20221213213850.1481858-2D2-2Dpeterx-40redhat.com_mbox&d=DwIDaQ&c=s883GpUCOChKOHiocYtGcg&r=c4KON2DiMd-szjwjggQcuUvTsPWblztAL0gVzaHnNmc&m=UYXwYmi1YA2mdAgHNDIkmgh-Xbem8hmqgCedCRNaj-32GKMVK8X30wH3nnXE9VF9&s=wD5Y-ZvvyUOVKpYHJkM7M8znJ3BjjpkbRIE1NVlMloI&e=
> > >
> > > While Manish's patch only has one line:
> > >
> > >    Content-Type: text/plain; charset="utf-8"
> > >    
> > > https://urldefense.proofpoint.com/v2/url?u=https-3A__patchew.org_QEMU_20221123172735.25181-2D2-2Dmanish.mishra-40nutanix.com_mbox&d=DwIDaQ&c=s883GpUCOChKOHiocYtGcg&r=c4KON2DiMd-szjwjggQcuUvTsPWblztAL0gVzaHnNmc&m=UYXwYmi1YA2mdAgHNDIkmgh-Xbem8hmqgCedCRNaj-32GKMVK8X30wH3nnXE9VF9&s=eQ3eyB3GvzUzyHdjTlWTt14dw4x0PL2xSbmXWPfN104&e=
> > Don't trust what is shown by patchew, as that's been through many
> > hops.
> >
> > The copy I receieved came directly to me via CC, so didn't hit mailman,
> > nor patchew, and that *only* has  "Content-type: text/plain".  So the
> > extra Content-type line with utf8 must have been added either by
> > mailman or patchew.
> >
> > So it probably looks like a config problem in the tool you use to send
> > the patches originally.
> Ouch... for misterious reasons I had one line in .gitconfig:
>
> 177 [format]
> 178         headers = "Content-type: text/plain"
>
> And that'll also affect git-publish too...  I have it dropped now.
>
> Thanks,