[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] configure: Fix check-tcg not executing any tests
From: |
Alex Bennée |
Subject: |
Re: [PATCH] configure: Fix check-tcg not executing any tests |
Date: |
Fri, 16 Dec 2022 15:04:56 +0000 |
User-agent: |
mu4e 1.9.6; emacs 29.0.60 |
Mukilan Thiyagarajan <quic_mthiyaga@quicinc.com> writes:
> After configuring with --target-list=hexagon-linux-user
> running `make check-tcg` just prints the following:
>
> ```
> make: Nothing to be done for 'check-tcg'
> ```
>
> In the probe_target_compiler function, the 'break'
> command is used incorrectly. There are no lexically
> enclosing loops associated with that break command which
> is an unspecfied behaviour in the POSIX standard.
>
> The dash shell implementation aborts the currently executing
> loop, in this case, causing the rest of the logic for the loop
> in line 2490 to be skipped, which means no Makefiles are
> generated for the tcg target tests.
>
> Fixes: c3b570b5a9a24d25 (configure: don't enable
> cross compilers unless in target_list)
>
> Signed-off-by: Mukilan Thiyagarajan <quic_mthiyaga@quicinc.com>
Queued to testing/next, thanks.
--
Alex Bennée
Virtualisation Tech Lead @ Linaro