[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] target/arm: align exposed ID registers with Linux
From: |
Zhuojia Shen |
Subject: |
Re: [PATCH v2] target/arm: align exposed ID registers with Linux |
Date: |
Fri, 16 Dec 2022 11:42:49 -0800 |
User-agent: |
Mutt/2.2.9 (2022-11-12) |
On 12/16/2022 03:41 PM +0000, Peter Maydell wrote:
> On Thu, 1 Dec 2022 at 16:46, Peter Maydell <peter.maydell@linaro.org> wrote:
> >
> > On Tue, 22 Nov 2022 at 23:25, Zhuojia Shen <chaosdefinition@hotmail.com>
> > wrote:
> > >
> > > In CPUID registers exposed to userspace, some registers were missing
> > > and some fields were not exposed. This patch aligns exposed ID
> > > registers and their fields with what the upstream kernel currently
> > > exposes.
> >
> > Thanks; I've applied this to the target-arm-for-8.0 branch that
> > will become target-arm.next when 7.2 is out.
>
> Hi; unfortunately I had to drop this patch because it causes the
> 'sysregs' test case in 'make check-tcg' to fail.
>
> Once you've built the test cases once, you can run the single
> test with something like:
> $ ./build/arm-clang/qemu-aarch64
> build/arm-clang/tests/tcg/aarch64-linux-user/sysregs
> which then will give you the output.
>
> It looks like the test is hard-coded to check that an expected
> set of fields is exposed, so it should be straightforward to
> update to match what we now intend to provide to the guest.
> Would you mind respinning this patch to include the update to
> the test case tests/tcg/aarch64/sysregs.c ?
Thanks for letting me know. I'll update the test.
Best,
Zhuojia