Re: [PATCH 3/5] accel/tcg: Restrict 'qapi-commands-machine.h' to system emulation

[Richard Henderson]

On 12/19/22 09:08, Philippe Mathieu-Daudé wrote:
> Since commit a0e61807a3 ("qapi: Remove QMP events and commands from
> user-mode builds") we don't generate the "qapi-commands-machine.h"
> header in a user-emulation-only build.
>
> Rename 'hmp.c' as 'monitor.c' and move the QMP functions from
> cpu-exec.c (which is always compiled) to monitor.c (which is only
> compiled when system-emulation is selected).
>
> Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org>
> ---
>   accel/tcg/cpu-exec.c  |  88 +----------------------------------
>   accel/tcg/hmp.c       |  14 ------
>   accel/tcg/internal.h  |   3 ++
>   accel/tcg/meson.build |   2 +-
>   accel/tcg/monitor.c   | 105 ++++++++++++++++++++++++++++++++++++++++++
>   5 files changed, 111 insertions(+), 101 deletions(-)
>   delete mode 100644 accel/tcg/hmp.c
>   create mode 100644 accel/tcg/monitor.c

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~