Re: [PATCH 5/4] target/i386: Restrict 'qapi-commands-machine.h' to system emulation

[Philippe Mathieu-Daudé]

On 20/12/22 01:01, Richard Henderson wrote:
> On 12/19/22 13:22, Philippe Mathieu-Daudé wrote:
> > From: Philippe Mathieu-Daude<philmd@linaro.org>
> >
> > Since commit a0e61807a3 ("qapi: Remove QMP events and commands from
> > user-mode builds") we don't generate the "qapi-commands-machine.h"
> > header in a user-emulation-only build.
> >
> > Guard qmp_query_cpu_definitions() within CONFIG_USER_ONLY; move
> > x86_cpu_class_check_missing_features() closer since it is only used
> > by this QMP command handler.
> >
> > Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org>
> > ---
> >   target/i386/cpu.c | 74 +++++++++++++++++++++++++----------------------
> >   1 file changed, 39 insertions(+), 35 deletions(-)
>
> Not moving these out to a separate file?  Anyway,

Few static functions are used, making it hard to split it out.
I'll have another look.

> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

Thanks!