[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 01/18] ui: Check numeric part of expire_password argument
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH v3 01/18] ui: Check numeric part of expire_password argument @time properly |
Date: |
Tue, 20 Dec 2022 09:10:47 +0000 |
User-agent: |
Mutt/2.2.7 (2022-08-07) |
On Tue, Dec 20, 2022 at 10:06:28AM +0100, Markus Armbruster wrote:
> When argument @time isn't 'now' or 'never', we parse it as an integer,
> optionally prefixed with '+'. If parsing fails, we silently assume
> zero. Report an error and fail instead.
>
> While there, use qemu_strtou64() instead of strtoull() so
> checkpatch.pl won't complain.
>
> Aside: encoding numbers in strings is bad QMP practice.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> monitor/qmp-cmds.c | 17 +++++++++++++++--
> 1 file changed, 15 insertions(+), 2 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [PATCH v3 00/18] ui: Move and clean up monitor command code, Markus Armbruster, 2022/12/20
- [PATCH v3 02/18] ui: Fix silent truncation of numeric keys in HMP sendkey, Markus Armbruster, 2022/12/20
- [PATCH v3 04/18] Revert "hmp: info spice: take out webdav", Markus Armbruster, 2022/12/20
- [PATCH v3 10/18] ui: Factor out qmp_add_client() parts and move to ui/ui-qmp-cmds.c, Markus Armbruster, 2022/12/20
- [PATCH v3 09/18] ui: Move QMP commands from monitor to new ui/ui-qmp-cmds.c, Markus Armbruster, 2022/12/20
- [PATCH v3 01/18] ui: Check numeric part of expire_password argument @time properly, Markus Armbruster, 2022/12/20
- Re: [PATCH v3 01/18] ui: Check numeric part of expire_password argument @time properly,
Daniel P . Berrangé <=
- [PATCH v3 13/18] ui: Improve "change vnc" error reporting, Markus Armbruster, 2022/12/20
- [PATCH v3 18/18] ui: Simplify control flow in qemu_mouse_set(), Markus Armbruster, 2022/12/20
- [PATCH v3 07/18] ui/spice: Give hmp_info_spice()'s channel_names[] static linkage, Markus Armbruster, 2022/12/20
- [PATCH v3 06/18] ui/spice: QXLInterface method set_mm_time() is now dead, drop, Markus Armbruster, 2022/12/20
- [PATCH v3 03/18] ui/spice: Require spice-protocol >= 0.14.0, Markus Armbruster, 2022/12/20
- [PATCH v3 14/18] ui: Factor out hmp_change_vnc(), and move to ui/ui-hmp-cmds.c, Markus Armbruster, 2022/12/20
- [PATCH v3 15/18] ui: Reduce nesting in hmp_change_vnc() slightly, Markus Armbruster, 2022/12/20
- [PATCH v3 12/18] ui: Move more HMP commands from monitor to ui/, Markus Armbruster, 2022/12/20