qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/3] accel: Silent few -Wmissing-field-initializers warning


From: Daniel P . Berrangé
Subject: Re: [PATCH 0/3] accel: Silent few -Wmissing-field-initializers warning
Date: Tue, 20 Dec 2022 14:42:35 +0000
User-agent: Mutt/2.2.7 (2022-08-07)

On Tue, Dec 20, 2022 at 03:35:29PM +0100, Philippe Mathieu-Daudé wrote:
> Silent few -Wmissing-field-initializers warnings enabled by -Wextra.
> 
> Philippe Mathieu-Daudé (3):
>   tcg: Silent -Wmissing-field-initializers warning
>   accel/kvm: Silent -Wmissing-field-initializers warning
>   softmmu: Silent -Wmissing-field-initializers warning
> 
>  accel/kvm/kvm-all.c | 4 ++--
>  softmmu/vl.c        | 2 +-
>  tcg/tcg-common.c    | 2 +-
>  3 files changed, 4 insertions(+), 4 deletions(-)

If we're going to the trouble of fixing violations (which is
good), then we shouuld also add  -Wmissing-field-initializers
(or -Wextra) to warn_flags in configure, to prevent regressions
again in future.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




reply via email to

[Prev in Thread] Current Thread [Next in Thread]