Re: [PATCH 7/7] libvhost-user: Switch to unsigned int for inuse field in struct VuVirtq

[Michael S. Tsirkin]

On Mon, Dec 19, 2022 at 06:53:37PM +0100, Marcel Holtmann wrote:
> It seems there is no need to keep the inuse field signed and end up with
> compiler warnings for sign-compare.
> 
>   CC       libvhost-user.o
> libvhost-user.c: In function ‘vu_queue_pop’:
> libvhost-user.c:2763:19: error: comparison of integer expressions of 
> different signedness: ‘int’ and ‘unsigned int’ [-Werror=sign-compare]
>  2763 |     if (vq->inuse >= vq->vring.num) {
>       |                   ^~
> libvhost-user.c: In function ‘vu_queue_rewind’:
> libvhost-user.c:2808:13: error: comparison of integer expressions of 
> different signedness: ‘unsigned int’ and ‘int’ [-Werror=sign-compare]
>  2808 |     if (num > vq->inuse) {
>       |             ^
> 
> Instead of casting the comparision to unsigned int, just make the inuse
> field unsigned int in the fist place.
> 
> Signed-off-by: Marcel Holtmann <marcel@holtmann.org>


Is this a part of a patchset? No threading visible and I'd rather not
guess.

> ---
>  subprojects/libvhost-user/libvhost-user.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/subprojects/libvhost-user/libvhost-user.h 
> b/subprojects/libvhost-user/libvhost-user.h
> index aea7ec5061d5..8cda9b8f577a 100644
> --- a/subprojects/libvhost-user/libvhost-user.h
> +++ b/subprojects/libvhost-user/libvhost-user.h
> @@ -343,7 +343,7 @@ typedef struct VuVirtq {
>      /* Notification enabled? */
>      bool notification;
>  
> -    int inuse;
> +    unsigned int inuse;
>  
>      vu_queue_handler_cb handler;
>  
> -- 
> 2.38.1
> 
> 
>