qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 05/10] libvhost-user: Declare uffdio_register early to mak


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v2 05/10] libvhost-user: Declare uffdio_register early to make it C90 compliant
Date: Tue, 20 Dec 2022 22:49:19 +0100
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.0

On 20/12/22 20:27, Marcel Holtmann wrote:
When using libvhost-user source in an external project that wants to
comply with the C90 standard, it is best to declare variables before
code.

   CC       libvhost-user.o
libvhost-user.c: In function ‘generate_faults’:
libvhost-user.c:683:9: error: ISO C90 forbids mixed declarations and code 
[-Werror=declaration-after-statement]
   683 |         struct uffdio_register reg_struct;
       |         ^~~~~~

In this case, it is also simple enough and doesn't cause any extra
ifdef additions.

Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
---
  subprojects/libvhost-user/libvhost-user.c | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]