[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL v2 13/14] accel/tcg: Factor tb_invalidate_phys_range_fast() out
From: |
Richard Henderson |
Subject: |
[PULL v2 13/14] accel/tcg: Factor tb_invalidate_phys_range_fast() out |
Date: |
Tue, 20 Dec 2022 21:03:12 -0800 |
From: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20221209093649.43738-5-philmd@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
accel/tcg/internal.h | 3 +++
accel/tcg/cputlb.c | 5 +----
accel/tcg/tb-maint.c | 21 +++++++++++++++++----
3 files changed, 21 insertions(+), 8 deletions(-)
diff --git a/accel/tcg/internal.h b/accel/tcg/internal.h
index d10ab69ed0..8f8c44d06b 100644
--- a/accel/tcg/internal.h
+++ b/accel/tcg/internal.h
@@ -42,6 +42,9 @@ void tb_invalidate_phys_page_fast__locked(struct
page_collection *pages,
uintptr_t retaddr);
struct page_collection *page_collection_lock(tb_page_addr_t start,
tb_page_addr_t end);
+void tb_invalidate_phys_range_fast(ram_addr_t ram_addr,
+ unsigned size,
+ uintptr_t retaddr);
void page_collection_unlock(struct page_collection *set);
G_NORETURN void cpu_io_recompile(CPUState *cpu, uintptr_t retaddr);
#endif /* CONFIG_SOFTMMU */
diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c
index f7963d3af8..03674d598f 100644
--- a/accel/tcg/cputlb.c
+++ b/accel/tcg/cputlb.c
@@ -1508,10 +1508,7 @@ static void notdirty_write(CPUState *cpu, vaddr
mem_vaddr, unsigned size,
trace_memory_notdirty_write_access(mem_vaddr, ram_addr, size);
if (!cpu_physical_memory_get_dirty_flag(ram_addr, DIRTY_MEMORY_CODE)) {
- struct page_collection *pages
- = page_collection_lock(ram_addr, ram_addr + size);
- tb_invalidate_phys_page_fast__locked(pages, ram_addr, size, retaddr);
- page_collection_unlock(pages);
+ tb_invalidate_phys_range_fast(ram_addr, size, retaddr);
}
/*
diff --git a/accel/tcg/tb-maint.c b/accel/tcg/tb-maint.c
index 8edfd910c4..d557013f00 100644
--- a/accel/tcg/tb-maint.c
+++ b/accel/tcg/tb-maint.c
@@ -1184,10 +1184,6 @@ void tb_invalidate_phys_range(tb_page_addr_t start,
tb_page_addr_t end)
}
/*
- * len must be <= 8 and start must be a multiple of len.
- * Called via softmmu_template.h when code areas are written to with
- * iothread mutex not held.
- *
* Call with all @pages in the range [@start, @start + len[ locked.
*/
void tb_invalidate_phys_page_fast__locked(struct page_collection *pages,
@@ -1205,4 +1201,21 @@ void tb_invalidate_phys_page_fast__locked(struct
page_collection *pages,
tb_invalidate_phys_page_range__locked(pages, p, start, start + len,
retaddr);
}
+
+/*
+ * len must be <= 8 and start must be a multiple of len.
+ * Called via softmmu_template.h when code areas are written to with
+ * iothread mutex not held.
+ */
+void tb_invalidate_phys_range_fast(ram_addr_t ram_addr,
+ unsigned size,
+ uintptr_t retaddr)
+{
+ struct page_collection *pages;
+
+ pages = page_collection_lock(ram_addr, ram_addr + size);
+ tb_invalidate_phys_page_fast__locked(pages, ram_addr, size, retaddr);
+ page_collection_unlock(pages);
+}
+
#endif /* CONFIG_USER_ONLY */
--
2.34.1
- [PULL v2 02/14] accel/tcg: Rename page_flush_tb, (continued)
- [PULL v2 02/14] accel/tcg: Rename page_flush_tb, Richard Henderson, 2022/12/21
- [PULL v2 01/14] util: Add interval-tree.c, Richard Henderson, 2022/12/21
- [PULL v2 03/14] accel/tcg: Use interval tree for TBs in user-only mode, Richard Henderson, 2022/12/21
- [PULL v2 04/14] accel/tcg: Use interval tree for TARGET_PAGE_DATA_SIZE, Richard Henderson, 2022/12/21
- [PULL v2 05/14] accel/tcg: Drop PAGE_RESERVED for CONFIG_BSD, Richard Henderson, 2022/12/21
- [PULL v2 06/14] accel/tcg: Move page_{get,set}_flags to user-exec.c, Richard Henderson, 2022/12/21
- [PULL v2 07/14] accel/tcg: Use interval tree for user-only page tracking, Richard Henderson, 2022/12/21
- [PULL v2 08/14] accel/tcg: Move PageDesc tree into tb-maint.c for system, Richard Henderson, 2022/12/21
- [PULL v2 10/14] accel/tcg: Restrict cpu_io_recompile() to system emulation, Richard Henderson, 2022/12/21
- [PULL v2 09/14] accel/tcg: Move remainder of page locking to tb-maint.c, Richard Henderson, 2022/12/21
- [PULL v2 13/14] accel/tcg: Factor tb_invalidate_phys_range_fast() out,
Richard Henderson <=
- [PULL v2 14/14] accel/tcg: Restrict page_collection structure to system TB maintainance, Richard Henderson, 2022/12/21
- [PULL v2 12/14] accel/tcg: Rename tb_invalidate_phys_page_fast{, __locked}(), Richard Henderson, 2022/12/21
- [PULL v2 11/14] accel/tcg: Remove trace events from trace-root.h, Richard Henderson, 2022/12/21
- Re: [PULL v2 00/14] accel/tcg: Rewrite user-only vma tracking, Peter Maydell, 2022/12/21