qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/3] hw/arm/nseries: Silent -Wmissing-field-initializers warn


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 3/3] hw/arm/nseries: Silent -Wmissing-field-initializers warning
Date: Wed, 21 Dec 2022 08:16:14 +0100
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.0

On 21/12/22 02:01, Richard Henderson wrote:
On 12/20/22 06:25, Philippe Mathieu-Daudé wrote:
Silent when compiling with -Wextra:

   ../hw/arm/nseries.c:1081:12: warning: missing field 'line' initializer [-Wmissing-field-initializers]
       { NULL }
              ^

Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org>
---
  hw/arm/nseries.c | 10 ++++------
  1 file changed, 4 insertions(+), 6 deletions(-)

Not a fan of this specific warning.

Me neither, and I don't think we can enforce it on QEMU codebase.

However I find '{ /* end of list */ }' cleaner/clearer than assigning
the first field.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]