[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 1/6] configure: Fix check-tcg not executing any tests
From: |
Alex Bennée |
Subject: |
[PATCH v2 1/6] configure: Fix check-tcg not executing any tests |
Date: |
Wed, 21 Dec 2022 09:04:06 +0000 |
From: Mukilan Thiyagarajan <quic_mthiyaga@quicinc.com>
After configuring with --target-list=hexagon-linux-user
running `make check-tcg` just prints the following:
```
make: Nothing to be done for 'check-tcg'
```
In the probe_target_compiler function, the 'break'
command is used incorrectly. There are no lexically
enclosing loops associated with that break command which
is an unspecfied behaviour in the POSIX standard.
The dash shell implementation aborts the currently executing
loop, in this case, causing the rest of the logic for the loop
in line 2490 to be skipped, which means no Makefiles are
generated for the tcg target tests.
Fixes: c3b570b5a9a24d25 (configure: don't enable
cross compilers unless in target_list)
Signed-off-by: Mukilan Thiyagarajan <quic_mthiyaga@quicinc.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Link:
https://patchew.org/QEMU/20221207082309.9966-1-quic._5Fmthiyaga@quicinc.com/
Message-Id: <20221207082309.9966-1-quic_mthiyaga@quicinc.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
configure | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/configure b/configure
index 26c7bc5154..7a804fb657 100755
--- a/configure
+++ b/configure
@@ -1881,9 +1881,7 @@ probe_target_compiler() {
# We shall skip configuring the target compiler if the user didn't
# bother enabling an appropriate guest. This avoids building
# extraneous firmware images and tests.
- if test "${target_list#*$1}" != "$1"; then
- break;
- else
+ if test "${target_list#*$1}" = "$1"; then
return 1
fi
--
2.34.1
- [PATCH v2 0/6] current status of testing/next, Alex Bennée, 2022/12/21
- [PATCH v2 1/6] configure: Fix check-tcg not executing any tests,
Alex Bennée <=
- [PATCH v2 4/6] tests/tcg: fix unused variable in linux-test, Alex Bennée, 2022/12/21
- [PATCH v2 5/6] tests/docker: use prebuilt toolchain for debian-hexagon-cross, Alex Bennée, 2022/12/21
- [PATCH v2 6/6] gitlab-ci: Disable docs and GUIs for the build-tci and build-tcg-disabled jobs, Alex Bennée, 2022/12/21
- [PATCH v2 3/6] configure: repeat ourselves for the benefit of CI, Alex Bennée, 2022/12/21
- [PATCH v2 2/6] gitlab: turn off verbose logging for make check on custom runners, Alex Bennée, 2022/12/21
- Re: [PATCH v2 0/6] current status of testing/next, Philippe Mathieu-Daudé, 2022/12/21