Re: [RFC PATCH v2 20/22] i386/xen: HVMOP_set_param / HVM_PARAM_CALLBACK_IRQ

[David Woodhouse]

On 21 December 2022 09:37:36 GMT, Paul Durrant <xadimgnik@gmail.com> wrote:
>On 21/12/2022 01:41, David Woodhouse wrote:
>>>> +    exit->u.hcall.result = err;
>>> 
>>> This is a bit on the ugly side isn't it? Why not return the err and have
>>> kvm_xen_hcall_hvm_op() deal with passing it back?
>> 
>> Because 'return false' means qemu will whine about it being
>> unimplemented.
>> 
>
>Ah, ok. Yes, I did suggest turning that into a trace, which would mean that 
>only those who cared would see such a whine.

We have both a trace *and* the UNIMPL warning. Neither are enabled by default.