[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 03/10] libvhost-user: Cast rc variable to avoid compiler warni
From: |
Marcel Holtmann |
Subject: |
[PATCH v3 03/10] libvhost-user: Cast rc variable to avoid compiler warning |
Date: |
Wed, 21 Dec 2022 14:10:19 +0100 |
The assert from recvmsg() return value against an uint32_t size field
from a protocol struct throws a compiler warning.
CC libvhost-user.o
In file included from libvhost-user.c:27:
libvhost-user.c: In function ‘vu_message_read_default’:
libvhost-user.c:363:19: error: comparison of integer expressions of different
signedness: ‘int’ and ‘uint32_t’ {aka ‘unsigned int’} [-Werror=sign-compare]
363 | assert(rc == vmsg->size);
| ^~
This is not critical, but annoying when the libvhost-user source are
used in an external project that has this compiler warning switched on.
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
---
subprojects/libvhost-user/libvhost-user.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/subprojects/libvhost-user/libvhost-user.c
b/subprojects/libvhost-user/libvhost-user.c
index 67d75ece53b7..bcdf32a24f60 100644
--- a/subprojects/libvhost-user/libvhost-user.c
+++ b/subprojects/libvhost-user/libvhost-user.c
@@ -339,7 +339,7 @@ vu_message_read_default(VuDev *dev, int conn_fd,
VhostUserMsg *vmsg)
goto fail;
}
- assert(rc == vmsg->size);
+ assert((uint32_t)rc == vmsg->size);
}
return true;
--
2.38.1
- [PATCH v3 00/10] Compiler warning fixes for libvhost-user,libvduse, Marcel Holtmann, 2022/12/21
- [PATCH v3 01/10] libvhost-user: Provide _GNU_SOURCE when compiling outside of QEMU, Marcel Holtmann, 2022/12/21
- [PATCH v3 05/10] libvhost-user: Declare uffdio_register early to make it C90 compliant, Marcel Holtmann, 2022/12/21
- [PATCH v3 04/10] libvhost-user: Use unsigned int i for some for-loop iterations, Marcel Holtmann, 2022/12/21
- [PATCH v3 07/10] libvhost-user: Switch to unsigned int for inuse field in struct VuVirtq, Marcel Holtmann, 2022/12/21
- [PATCH v3 08/10] libvduse: Provide _GNU_SOURCE when compiling outside of QEMU, Marcel Holtmann, 2022/12/21
- [PATCH v3 03/10] libvhost-user: Cast rc variable to avoid compiler warning,
Marcel Holtmann <=
- [PATCH v3 02/10] libvhost-user: Replace typeof with __typeof__, Marcel Holtmann, 2022/12/21
- [PATCH v3 06/10] libvhost-user: Change dev->postcopy_ufd assignment to make it C90 compliant, Marcel Holtmann, 2022/12/21
- [PATCH v3 10/10] libvduse: Fix assignment in vring_set_avail_event, Marcel Holtmann, 2022/12/21
- [PATCH v3 09/10] libvduse: Switch to unsigned int for inuse field in struct VduseVirtq, Marcel Holtmann, 2022/12/21