[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 21/30] hw/isa/piix4: Remove unused inbound ISA interrupt lines
From: |
Bernhard Beschow |
Subject: |
[PATCH v4 21/30] hw/isa/piix4: Remove unused inbound ISA interrupt lines |
Date: |
Wed, 21 Dec 2022 17:59:54 +0100 |
The Malta board, which is the only user of PIIX4, doesn't connect to the
exported interrupt lines. PIIX3 doesn't expose such intterupt lines
either, so remove them for PIIX4 for simplicity and consistency.
Signed-off-by: Bernhard Beschow <shentey@gmail.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Message-Id: <20221022150508.26830-32-shentey@gmail.com>
---
hw/isa/piix4.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/hw/isa/piix4.c b/hw/isa/piix4.c
index de4133f573..9edaa5de3e 100644
--- a/hw/isa/piix4.c
+++ b/hw/isa/piix4.c
@@ -155,12 +155,6 @@ static void piix4_request_i8259_irq(void *opaque, int irq,
int level)
qemu_set_irq(s->cpu_intr, level);
}
-static void piix4_set_i8259_irq(void *opaque, int irq, int level)
-{
- PIIX4State *s = opaque;
- qemu_set_irq(s->isa[irq], level);
-}
-
static void piix4_rcr_write(void *opaque, hwaddr addr, uint64_t val,
unsigned int len)
{
@@ -204,8 +198,6 @@ static void piix4_realize(PCIDevice *dev, Error **errp)
return;
}
- qdev_init_gpio_in_named(DEVICE(dev), piix4_set_i8259_irq,
- "isa", ISA_NUM_IRQS);
qdev_init_gpio_out_named(DEVICE(dev), &s->cpu_intr,
"intr", 1);
--
2.39.0
- [PATCH v4 19/30] hw/isa/piix3: Drop the "3" from PIIX base class, (continued)
- [PATCH v4 19/30] hw/isa/piix3: Drop the "3" from PIIX base class, Bernhard Beschow, 2022/12/21
- [PATCH v4 15/30] hw/isa/piix3: Wire up ACPI interrupt internally, Bernhard Beschow, 2022/12/21
- [PATCH v4 23/30] hw/isa/piix4: Reuse struct PIIXState from PIIX3, Bernhard Beschow, 2022/12/21
- [PATCH v4 24/30] hw/isa/piix4: Rename reset control operations to match PIIX3, Bernhard Beschow, 2022/12/21
- [PATCH v4 26/30] hw/isa/piix: Harmonize names of reset control memory regions, Bernhard Beschow, 2022/12/21
- [PATCH v4 12/30] hw/core: Introduce proxy-pic, Bernhard Beschow, 2022/12/21
- [PATCH v4 20/30] hw/isa/piix4: Make PIIX4's ACPI and USB functions optional, Bernhard Beschow, 2022/12/21
- [PATCH v4 25/30] hw/isa/piix3: Merge hw/isa/piix4.c, Bernhard Beschow, 2022/12/21
- [PATCH v4 17/30] hw/isa/piix3: Rename pci_piix3_props for sharing with PIIX4, Bernhard Beschow, 2022/12/21
- [PATCH v4 16/30] hw/isa/piix3: Resolve redundant PIIX_NUM_PIC_IRQS, Bernhard Beschow, 2022/12/21
- [PATCH v4 21/30] hw/isa/piix4: Remove unused inbound ISA interrupt lines,
Bernhard Beschow <=
- [PATCH v4 27/30] hw/isa/piix: Reuse PIIX3 base class' realize method in PIIX4, Bernhard Beschow, 2022/12/21
- [PATCH v4 28/30] hw/isa/piix: Rename functions to be shared for interrupt triggering, Bernhard Beschow, 2022/12/21
- [PATCH v4 29/30] hw/isa/piix: Consolidate IRQ triggering, Bernhard Beschow, 2022/12/21
- [PATCH v4 30/30] hw/isa/piix: Share PIIX3's base class with PIIX4, Bernhard Beschow, 2022/12/21
- Re: [PATCH v4 00/30] This series consolidates the implementations of the PIIX3 and PIIX4 south, Philippe Mathieu-Daudé, 2022/12/21