qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] target/hexagon: suppress unused variable warning


From: Richard Henderson
Subject: Re: [PATCH] target/hexagon: suppress unused variable warning
Date: Wed, 21 Dec 2022 09:42:32 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2

On 12/21/22 07:43, Taylor Simpson wrote:
--- a/target/hexagon/idef-parser/idef-parser.y
+++ b/target/hexagon/idef-parser/idef-parser.y
@@ -99,6 +99,8 @@
  /* Input file containing the description of each hexagon instruction */  
input :
instructions
        {
+          // Suppress warning about unused yynerrs
+          (void) yynerrs;
            YYACCEPT;
        }
        ;

According to this page
https://qemu-project.gitlab.io/qemu/devel/style.html#comment-style
we should avoid // comments, and the checkpatch script will warn about this.  
However, checkpatch does not warn on this patch.

It does not process *.y.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]