[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 08/15] hw/riscv: write bootargs 'chosen' FDT after riscv_load
|
From: |
Bin Meng |
|
Subject: |
Re: [PATCH 08/15] hw/riscv: write bootargs 'chosen' FDT after riscv_load_kernel() |
|
Date: |
Fri, 23 Dec 2022 18:32:23 +0800 |
On Thu, Dec 22, 2022 at 2:24 AM Daniel Henrique Barboza
<dbarboza@ventanamicro.com> wrote:
>
> The sifive_u, spike and virt machines are writing the 'bootargs' FDT
> node during their respective create_fdt().
>
> Given that bootargs is written only when '-append' is used, and this
> option is only allowed with the '-kernel' option, which in turn is
> already being check before executing riscv_load_kernel(), write
being checked
> 'bootargs' in the same code path as riscv_load_kernel().
>
> Cc: Palmer Dabbelt <palmer@dabbelt.com>
> Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
> ---
> hw/riscv/sifive_u.c | 11 +++++------
> hw/riscv/spike.c | 9 +++++----
> hw/riscv/virt.c | 11 +++++------
> 3 files changed, 15 insertions(+), 16 deletions(-)
>
Reviewed-by: Bin Meng <bmeng@tinylab.org>
- [PATCH 05/15] hw/riscv/boot.c: introduce riscv_default_firmware_name(), (continued)
- [PATCH 05/15] hw/riscv/boot.c: introduce riscv_default_firmware_name(), Daniel Henrique Barboza, 2022/12/21
- [PATCH 06/15] hw/riscv/spike.c: load initrd right after riscv_load_kernel(), Daniel Henrique Barboza, 2022/12/21
- [PATCH 07/15] hw/riscv: write initrd 'chosen' FDT inside riscv_load_initrd(), Daniel Henrique Barboza, 2022/12/21
- [PATCH 08/15] hw/riscv: write bootargs 'chosen' FDT after riscv_load_kernel(), Daniel Henrique Barboza, 2022/12/21
- Re: [PATCH 08/15] hw/riscv: write bootargs 'chosen' FDT after riscv_load_kernel(),
Bin Meng <=
- [PATCH 09/15] hw/riscv/boot.c: use MachineState in riscv_load_initrd(), Daniel Henrique Barboza, 2022/12/21
- [PATCH 10/15] hw/riscv/boot.c: use MachineState in riscv_load_kernel(), Daniel Henrique Barboza, 2022/12/21
- [PATCH 11/15] hw/riscv/boot.c: consolidate all kernel init in riscv_load_kernel(), Daniel Henrique Barboza, 2022/12/21
- [PATCH 12/15] hw/riscv/boot.c: make riscv_load_initrd() static, Daniel Henrique Barboza, 2022/12/21