[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 1/5] 9pfs: Fix some return statements in the synth backend
From: |
Christian Schoenebeck |
Subject: |
[PULL 1/5] 9pfs: Fix some return statements in the synth backend |
Date: |
Fri, 23 Dec 2022 12:04:36 +0100 |
From: Greg Kurz <groug@kaod.org>
The qemu_v9fs_synth_mkdir() and qemu_v9fs_synth_add_file() functions
currently return a positive errno value on failure. This causes
checkpatch.pl to spit several errors like the one below:
ERROR: return of an errno should typically be -ve (return -EAGAIN)
+ return EAGAIN;
Simply change the sign. This has no consequence since callers
assert() the returned value to be equal to 0.
Reported-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Greg Kurz <groug@kaod.org>
Message-Id: <166930551818.827792.10663674346122681963.stgit@bahia>
[C.S.: - Resolve conflict with 66997c42e02c. ]
Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
---
hw/9pfs/9p-synth.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/hw/9pfs/9p-synth.c b/hw/9pfs/9p-synth.c
index 38d787f494..f62c40b639 100644
--- a/hw/9pfs/9p-synth.c
+++ b/hw/9pfs/9p-synth.c
@@ -75,10 +75,10 @@ int qemu_v9fs_synth_mkdir(V9fsSynthNode *parent, int mode,
V9fsSynthNode *node, *tmp;
if (!synth_fs) {
- return EAGAIN;
+ return -EAGAIN;
}
if (!name || (strlen(name) >= NAME_MAX)) {
- return EINVAL;
+ return -EINVAL;
}
if (!parent) {
parent = &synth_root;
@@ -86,7 +86,7 @@ int qemu_v9fs_synth_mkdir(V9fsSynthNode *parent, int mode,
QEMU_LOCK_GUARD(&synth_mutex);
QLIST_FOREACH(tmp, &parent->child, sibling) {
if (!strcmp(tmp->name, name)) {
- return EEXIST;
+ return -EEXIST;
}
}
/* Add the name */
@@ -106,10 +106,10 @@ int qemu_v9fs_synth_add_file(V9fsSynthNode *parent, int
mode,
V9fsSynthNode *node, *tmp;
if (!synth_fs) {
- return EAGAIN;
+ return -EAGAIN;
}
if (!name || (strlen(name) >= NAME_MAX)) {
- return EINVAL;
+ return -EINVAL;
}
if (!parent) {
parent = &synth_root;
@@ -118,7 +118,7 @@ int qemu_v9fs_synth_add_file(V9fsSynthNode *parent, int
mode,
QEMU_LOCK_GUARD(&synth_mutex);
QLIST_FOREACH(tmp, &parent->child, sibling) {
if (!strcmp(tmp->name, name)) {
- return EEXIST;
+ return -EEXIST;
}
}
/* Add file type and remove write bits */
--
2.30.2