Re: [PATCH 1/2] tests/migration: add sysprof-capture-4 as dependency for stress binary

[Daniel Henrique Barboza]

Until it's upstream or rejected, no patch will be left behind.


I wasn't able to compile tests/migration/stress at all without this patch,
regardless of having sysprof-4 libraries installed in the host.


Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>


Juan/Dr.David, if  you don't mind I'll take this via ppc-next since
there's a PPC only change that depends on it.



Daniel


On 8/8/22 21:24, Murilo Opsfelder Araujo wrote:
> `make tests/migration/stress` fails with:
>
>      FAILED: tests/migration/stress
>      cc -m64 -mlittle-endian  -o tests/migration/stress 
> tests/migration/stress.p/stress.c.o -Wl,--as-needed -Wl,--no-undefined -pie 
> -Wl,--warn-common -Wl,-z,relro -Wl,-z,now -fstack-protector-strong -static 
> -pthread -Wl,--start-group -lgthread-2.0 -lglib-2.0 -Wl,--end-group
>      /usr/bin/ld: 
> /usr/lib/gcc/ppc64le-redhat-linux/11/../../../../lib64/libglib-2.0.a(gutils.c.o):
>  in function `.annobin_gutils.c':
>      (.text+0x3b4): warning: Using 'getpwuid' in statically linked applications 
> requires at runtime the shared libraries from the glibc version used for linking
>      /usr/bin/ld: (.text+0x178): warning: Using 'getpwnam_r' in statically 
> linked applications requires at runtime the shared libraries from the glibc 
> version used for linking
>      /usr/bin/ld: (.text+0x1bc): warning: Using 'getpwuid_r' in statically 
> linked applications requires at runtime the shared libraries from the glibc 
> version used for linking
>      /usr/bin/ld: 
> /usr/lib/gcc/ppc64le-redhat-linux/11/../../../../lib64/libglib-2.0.a(gthread.c.o):(.toc+0x0):
>  undefined reference to `sysprof_clock'
>      /usr/bin/ld: 
> /usr/lib/gcc/ppc64le-redhat-linux/11/../../../../lib64/libglib-2.0.a(gtrace.c.o):
>  in function `.annobin_gtrace.c':
>      (.text+0x24): undefined reference to `sysprof_collector_mark_vprintf'
>      /usr/bin/ld: 
> /usr/lib/gcc/ppc64le-redhat-linux/11/../../../../lib64/libglib-2.0.a(gtrace.c.o):
>  in function `g_trace_define_int64_counter':
>      (.text+0x8c): undefined reference to `sysprof_collector_request_counters'
>      /usr/bin/ld: (.text+0x108): undefined reference to 
> `sysprof_collector_define_counters'
>      /usr/bin/ld: 
> /usr/lib/gcc/ppc64le-redhat-linux/11/../../../../lib64/libglib-2.0.a(gtrace.c.o):
>  in function `g_trace_set_int64_counter':
>      (.text+0x23c): undefined reference to `sysprof_collector_set_counters'
>      /usr/bin/ld: 
> /usr/lib/gcc/ppc64le-redhat-linux/11/../../../../lib64/libglib-2.0.a(gspawn.c.o):(.toc+0x0):
>  undefined reference to `sysprof_clock'
>      /usr/bin/ld: 
> /usr/lib/gcc/ppc64le-redhat-linux/11/../../../../lib64/libglib-2.0.a(gmain.c.o):(.toc+0x0):
>  undefined reference to `sysprof_clock'
>      collect2: error: ld returned 1 exit status
>      ninja: build stopped: subcommand failed.
>      make: *** [Makefile:162: run-ninja] Error 1
>
> Add sysprof-capture-4 as dependency for stress binary.
>
> Tested on:
>    - CentOS Stream 9 ppc64le
>    - Fedora 36 x86_64
>
> Signed-off-by: Murilo Opsfelder Araujo <muriloo@linux.ibm.com>
> ---
>   tests/migration/meson.build | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tests/migration/meson.build b/tests/migration/meson.build
> index f215ee7d3a..3fd87f7849 100644
> --- a/tests/migration/meson.build
> +++ b/tests/migration/meson.build
> @@ -1,7 +1,9 @@
> +sysprof = dependency('sysprof-capture-4')
> +
>   stress = executable(
>     'stress',
>     files('stress.c'),
> -  dependencies: [glib],
> +  dependencies: [glib, sysprof],
>     link_args: ['-static'],
>     build_by_default: false,
>   )