[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v5 09/43] target/riscv: Use QEMU_IOTHREAD_LOCK_GUARD in riscv_cpu
From: |
Richard Henderson |
Subject: |
[PATCH v5 09/43] target/riscv: Use QEMU_IOTHREAD_LOCK_GUARD in riscv_cpu_update_mip |
Date: |
Sat, 24 Dec 2022 15:56:46 -0800 |
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/riscv/cpu_helper.c | 10 +---------
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/target/riscv/cpu_helper.c b/target/riscv/cpu_helper.c
index 278d163803..241d06bab8 100644
--- a/target/riscv/cpu_helper.c
+++ b/target/riscv/cpu_helper.c
@@ -610,7 +610,6 @@ uint64_t riscv_cpu_update_mip(RISCVCPU *cpu, uint64_t mask,
uint64_t value)
CPURISCVState *env = &cpu->env;
CPUState *cs = CPU(cpu);
uint64_t gein, vsgein = 0, vstip = 0, old = env->mip;
- bool locked = false;
if (riscv_cpu_virt_enabled(env)) {
gein = get_field(env->hstatus, HSTATUS_VGEIN);
@@ -621,10 +620,7 @@ uint64_t riscv_cpu_update_mip(RISCVCPU *cpu, uint64_t
mask, uint64_t value)
mask = ((mask == MIP_VSTIP) && env->vstime_irq) ? 0 : mask;
vstip = env->vstime_irq ? MIP_VSTIP : 0;
- if (!qemu_mutex_iothread_locked()) {
- locked = true;
- qemu_mutex_lock_iothread();
- }
+ QEMU_IOTHREAD_LOCK_GUARD();
env->mip = (env->mip & ~mask) | (value & mask);
@@ -634,10 +630,6 @@ uint64_t riscv_cpu_update_mip(RISCVCPU *cpu, uint64_t
mask, uint64_t value)
cpu_reset_interrupt(cs, CPU_INTERRUPT_HARD);
}
- if (locked) {
- qemu_mutex_unlock_iothread();
- }
-
return old;
}
--
2.34.1
- [PATCH v5 00/43] tcg misc patches, Richard Henderson, 2022/12/24
- [PATCH v5 02/43] meson: Move CONFIG_TCG_INTERPRETER to config_host, Richard Henderson, 2022/12/24
- [PATCH v5 04/43] tcg: Cleanup trailing whitespace, Richard Henderson, 2022/12/24
- [PATCH v5 03/43] tcg/s390x: Fix coding style, Richard Henderson, 2022/12/24
- [PATCH v5 05/43] qemu/main-loop: Introduce QEMU_IOTHREAD_LOCK_GUARD, Richard Henderson, 2022/12/24
- [PATCH v5 07/43] target/ppc: Use QEMU_IOTHREAD_LOCK_GUARD in ppc_maybe_interrupt, Richard Henderson, 2022/12/24
- [PATCH v5 06/43] hw/mips: Use QEMU_IOTHREAD_LOCK_GUARD in cpu_mips_irq_request, Richard Henderson, 2022/12/24
- [PATCH v5 08/43] target/ppc: Use QEMU_IOTHREAD_LOCK_GUARD in cpu_interrupt_exittb, Richard Henderson, 2022/12/24
- [PATCH v5 01/43] tcg: convert tcg/README to rst, Richard Henderson, 2022/12/24
- [PATCH v5 09/43] target/riscv: Use QEMU_IOTHREAD_LOCK_GUARD in riscv_cpu_update_mip,
Richard Henderson <=
- [PATCH v5 12/43] tcg: Tidy tcg_reg_alloc_op, Richard Henderson, 2022/12/24
- [PATCH v5 11/43] accel/tcg: Use QEMU_IOTHREAD_LOCK_GUARD in io_readx/io_writex, Richard Henderson, 2022/12/24
- [PATCH v5 13/43] tcg: Remove TCG_TARGET_STACK_GROWSUP, Richard Henderson, 2022/12/24
- [PATCH v5 14/43] tci: MAX_OPC_PARAM_IARGS is no longer used, Richard Henderson, 2022/12/24
- [PATCH v5 10/43] hw/ppc: Use QEMU_IOTHREAD_LOCK_GUARD in ppc_set_irq, Richard Henderson, 2022/12/24
- [PATCH v5 15/43] tcg: Fix tcg_reg_alloc_dup*, Richard Henderson, 2022/12/24
- [PATCH v5 17/43] tcg: Remove check_regs, Richard Henderson, 2022/12/24
- [PATCH v5 18/43] tcg: Massage process_op_defs(), Richard Henderson, 2022/12/24
- [PATCH v5 20/43] accel/tcg: Set cflags_next_tb in cpu_common_initfn, Richard Henderson, 2022/12/24
- [PATCH v5 21/43] target/sparc: Avoid TCGV_{LOW,HIGH}, Richard Henderson, 2022/12/24