[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 24/47] tcg: Simplify calls to temp_sync vs mem_coherent
From: |
Richard Henderson |
Subject: |
[PULL 24/47] tcg: Simplify calls to temp_sync vs mem_coherent |
Date: |
Thu, 29 Dec 2022 16:01:58 -0800 |
The first thing that temp_sync does is check mem_coherent,
so there's no need for the caller to do so.
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
tcg/tcg.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/tcg/tcg.c b/tcg/tcg.c
index 4f2e05c69e..28ab174f1b 100644
--- a/tcg/tcg.c
+++ b/tcg/tcg.c
@@ -4078,12 +4078,8 @@ static bool tcg_reg_alloc_dup2(TCGContext *s, const
TCGOp *op)
/* If the two inputs form one 64-bit value, try dupm_vec. */
if (itsl + 1 == itsh && itsl->base_type == TCG_TYPE_I64) {
- if (!itsl->mem_coherent) {
- temp_sync(s, itsl, s->reserved_regs, 0, 0);
- }
- if (!itsh->mem_coherent) {
- temp_sync(s, itsh, s->reserved_regs, 0, 0);
- }
+ temp_sync(s, itsl, s->reserved_regs, 0, 0);
+ temp_sync(s, itsh, s->reserved_regs, 0, 0);
#if HOST_BIG_ENDIAN
TCGTemp *its = itsh;
#else
--
2.34.1
- [PULL 23/47] tcg: Add temp_subindex to TCGTemp, (continued)
- [PULL 23/47] tcg: Add temp_subindex to TCGTemp, Richard Henderson, 2022/12/29
- [PULL 35/47] tcg: Pass number of arguments to tcg_emit_op() / tcg_op_insert_*(), Richard Henderson, 2022/12/29
- [PULL 37/47] tcg: Use output_pref wrapper function, Richard Henderson, 2022/12/29
- [PULL 25/47] tcg: Allocate TCGTemp pairs in host memory order, Richard Henderson, 2022/12/29
- [PULL 27/47] tcg: Introduce tcg_type_size, Richard Henderson, 2022/12/29
- [PULL 31/47] tcg: Use TCG_CALL_ARG_EVEN for TCI special case, Richard Henderson, 2022/12/29
- [PULL 29/47] tcg: Replace TCG_TARGET_CALL_ALIGN_ARGS with TCG_TARGET_CALL_ARG_I64, Richard Henderson, 2022/12/29
- [PULL 39/47] tcg: Convert typecode_to_ffi from array to function, Richard Henderson, 2022/12/29
- [PULL 28/47] tcg: Introduce TCGCallReturnKind and TCGCallArgumentKind, Richard Henderson, 2022/12/29
- [PULL 32/47] accel/tcg/plugin: Don't search for the function pointer index, Richard Henderson, 2022/12/29
- [PULL 24/47] tcg: Simplify calls to temp_sync vs mem_coherent,
Richard Henderson <=
- [PULL 30/47] tcg: Replace TCG_TARGET_EXTEND_ARGS with TCG_TARGET_CALL_ARG_I32, Richard Henderson, 2022/12/29
- [PULL 38/47] tcg: Reorg function calls, Richard Henderson, 2022/12/29
- [PULL 42/47] tcg/aarch64: Merge tcg_out_callr into tcg_out_call, Richard Henderson, 2022/12/29
- [PULL 40/47] tcg: Factor init_ffi_layouts() out of tcg_context_init(), Richard Henderson, 2022/12/29
- [PULL 41/47] tcg: Move ffi_cif pointer into TCGHelperInfo, Richard Henderson, 2022/12/29
- [PULL 46/47] accel/tcg: Handle false negative lookup in page_check_range, Richard Henderson, 2022/12/29
- [PULL 44/47] accel/tcg: Fix tb_invalidate_phys_page_unwind, Richard Henderson, 2022/12/29
- [PULL 45/47] accel/tcg: Use g_free_rcu for user-exec interval trees, Richard Henderson, 2022/12/29
- [PULL 47/47] tests/tcg/multiarch: add vma-pthread.c, Richard Henderson, 2022/12/29